chrome/android/java/res/layout/account_signin_choice_description_view.xml - Issue 1840513002: Redesign sign in and sign in confirmation screens for Narnia 2.0

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/account_signin_choice_description_view.xml

Issue 1840513002: Redesign sign in and sign in confirmation screens for Narnia 2.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/account_signin_account_view.xml ('K') | « chrome/android/java/res/layout/account_signin_account_view.xml ('k') | chrome/android/java/res/layout/account_signin_view.xml » ('j') | chrome/android/java/res/layout/account_signin_view.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <TextView xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:id="@+id/signin_choice_description"

	8 android:layout_width="wrap_content"

	9 android:layout_height="wrap_content"

	10 android:layout_gravity="start"
	newt (away) 2016/04/01 23:43:10 layout_gravity positions this view within its pare layout_gravity positions this view within its parent. gravity positions the content within the TextView. Neither is needed here. gogerald1 2016/04/12 01:21:11 Done. Show quoted text On 2016/04/01 23:43:10, newt wrote: > layout_gravity positions this view within its parent. gravity positions the > content within the TextView. Neither is needed here. Done.
	11 android:gravity="start"

	12 android:paddingTop="16dp"

	13 android:paddingBottom="16dp"

	14 android:lineSpacingMultiplier="1.4"

	15 android:text="@string/signin_account_choice_description"

	16 android:textColor="@color/default_text_color"

	17 android:textSize="@dimen/fre_normal_text_size"/>

OLD	NEW