Issue 18405003: Update scroll layer positions in WebLayerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18405003: Update scroll layer positions in WebLayerImpl (Closed)

Created:
7 years, 5 months ago by enne (OOO)

Modified:
7 years, 5 months ago

Reviewers:
Ian Vollick, jamesr

CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, danakj

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update scroll layer positions in WebLayerImpl This is step 1 of a 3 step patch to disentangle Layer positions and scroll offsets. When scrolling frames, RLC always sets the layer position to be the negative scroll position. In order to remove this from Blink, duplicate that work in the compositor bindings. Step 2 is to make RLC not set scroll position when scrolling goes through the ScrollingCoordinator. See: https://codereview.chromium.org/18187004 Step 3 is to revert this patch and consider scroll offset when computing draw transforms. It's currently ignored. See: https://codereview.chromium.org/18400003 R=jamesr@chromium.org BUG=256381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210086

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	webkit/renderer/compositor_bindings/web_layer_impl.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/18405003/1

7 years, 5 months ago (2013-07-03 19:58:53 UTC) #3

Message was sent while issue was closed.

Change committed as 210086

Expand Messages | Collapse Messages