Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/javascript/Document.cpp

Issue 1840483003: Reduce signed/unsigned comparison warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fxcrt/include/fx_ext.h ('K') | « fpdfsdk/fxedit/fxet_edit.cpp ('k') | fpdfsdk/javascript/JS_Value.cpp » ('j') | fpdfsdk/pdfwindow/PWL_FontMap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/Document.cpp
diff --git a/fpdfsdk/javascript/Document.cpp b/fpdfsdk/javascript/Document.cpp
index 0b793db0497aa1748a33fbecb9ef606f4607a3cc..70b4ef7e032eacc936816088d9efccc0175972cc 100644
--- a/fpdfsdk/javascript/Document.cpp
+++ b/fpdfsdk/javascript/Document.cpp
@@ -1460,7 +1460,7 @@ int Document::CountWords(CPDF_TextObject* pTextObj) {
FX_BOOL bIsLatin = FALSE;
for (int i = 0, sz = pTextObj->CountChars(); i < sz; i++) {
- uint32_t charcode = static_cast<uint32_t>(-1);
+ uint32_t charcode = CPDF_Font::kInvalidCharCode;
FX_FLOAT kerning;
pTextObj->GetCharInfo(i, charcode, kerning);
@@ -1493,7 +1493,7 @@ CFX_WideString Document::GetObjWordStr(CPDF_TextObject* pTextObj,
FX_BOOL bIsLatin = FALSE;
for (int i = 0, sz = pTextObj->CountChars(); i < sz; i++) {
- uint32_t charcode = static_cast<uint32_t>(-1);
+ uint32_t charcode = CPDF_Font::kInvalidCharCode;
FX_FLOAT kerning;
pTextObj->GetCharInfo(i, charcode, kerning);
« core/fxcrt/include/fx_ext.h ('K') | « fpdfsdk/fxedit/fxet_edit.cpp ('k') | fpdfsdk/javascript/JS_Value.cpp » ('j') | fpdfsdk/pdfwindow/PWL_FontMap.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698