Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3449)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/fxge/ge/fx_ge_font.cpp

Issue 1840483003: Reduce signed/unsigned comparison warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fxcrt/include/fx_ext.h ('K') | « core/fxcrt/include/fx_ext.h ('k') | core/fxge/ge/fx_ge_fontmap.cpp » ('j') | fpdfsdk/pdfwindow/PWL_FontMap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxge/ge/fx_ge_font.cpp
diff --git a/core/fxge/ge/fx_ge_font.cpp b/core/fxge/ge/fx_ge_font.cpp
index b2c92f516da6b4b83a3f2aeca092a42580f92699..f9f6dbbd075ab3ecf0312d5a8aa467e2505077dd 100644
--- a/core/fxge/ge/fx_ge_font.cpp
+++ b/core/fxge/ge/fx_ge_font.cpp
@@ -4,6 +4,7 @@
// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
+#include "core/fpdfapi/fpdf_font/include/cpdf_font.h"
#include "core/fxge/ge/fx_text_int.h"
#include "core/include/fxge/fx_freetype.h"
#include "core/include/fxge/fx_ge.h"
@@ -516,7 +517,7 @@ FX_DWORD CFX_UnicodeEncodingEx::CharCodeFromUnicode(FX_WCHAR Unicode) const {
return Unicode;
}
}
- return static_cast<FX_DWORD>(-1);
+ return CPDF_Font::kInvalidCharCode;
}
CFX_UnicodeEncodingEx* FX_CreateFontEncodingEx(CFX_Font* pFont,
« core/fxcrt/include/fx_ext.h ('K') | « core/fxcrt/include/fx_ext.h ('k') | core/fxge/ge/fx_ge_fontmap.cpp » ('j') | fpdfsdk/pdfwindow/PWL_FontMap.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698