Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/renderer/resources/extensions/system_indicator_custom_bindings.js

Issue 1840453002: [Extensions] More bindings hardening (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the systemIndicator API. 5 // Custom binding for the systemIndicator API.
6 // TODO(dewittj) Refactor custom binding to reduce redundancy between the 6 // TODO(dewittj) Refactor custom binding to reduce redundancy between the
7 // extension action APIs. 7 // extension action APIs.
8 8
9 var binding = require('binding').Binding.create('systemIndicator'); 9 var binding = require('binding').Binding.create('systemIndicator');
10 10
11 var setIcon = require('setIcon').setIcon; 11 var setIcon = require('setIcon').setIcon;
12 var sendRequest = require('sendRequest').sendRequest; 12 var sendRequest = require('sendRequest').sendRequest;
13 13
14 binding.registerCustomHook(function(bindingsAPI) { 14 binding.registerCustomHook(function(bindingsAPI) {
15 var apiFunctions = bindingsAPI.apiFunctions; 15 var apiFunctions = bindingsAPI.apiFunctions;
16 16
17 apiFunctions.setHandleRequest('setIcon', function(details, callback) { 17 apiFunctions.setHandleRequest('setIcon', function(details, callback) {
18 setIcon(details, function(args) { 18 setIcon(details, function(args) {
19 sendRequest(this.name, [args, callback], this.definition.parameters); 19 sendRequest(this.name, [args, callback], this.definition.parameters);
20 }.bind(this)); 20 }.bind(this));
21 }); 21 });
22 }); 22 });
23 23
24 exports.binding = binding.generate(); 24 exports.$set('binding', binding.generate());
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698