Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 1840453002: [Extensions] More bindings hardening (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, rginda+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] More bindings hardening Revision 83a4b3aa72d98fe4176b4a54c8cea227ed966570 missed a few (c/r/resources/extensions). BUG=468931 BUG=591164 Committed: https://crrev.com/180e7e74926ea32ac039821926542452d1201c5e Cr-Commit-Position: refs/heads/master@{#383541}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -65 lines) Patch
M chrome/renderer/resources/extensions/app_custom_bindings.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/automation_custom_bindings.js View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/browser_action_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_receiver_session_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_rtp_stream_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_session_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_udp_transport_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/certificate_provider_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/chrome_direct_setting.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/chrome_setting.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/content_setting.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/declarative_content_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/desktop_capture_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/developer_private_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/downloads_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/enterprise_platform_keys/internal_api.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/enterprise_platform_keys_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/feedback_private_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/file_entry_binding_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/file_system_custom_bindings.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/gcm_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/identity_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/image_writer_private_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/input.ime_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/log_private_custom_bindings.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/media_galleries_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/notifications_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/notifications_test_util.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/omnibox_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/page_action_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/page_capture_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/platform_keys/get_public_key.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/platform_keys/internal_api.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/platform_keys/key.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/platform_keys/utils.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/platform_keys_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/sync_file_system_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/system_indicator_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/tab_capture_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/tabs_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/tag_watcher.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/tts_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/tts_engine_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/web_view/chrome_web_view_internal_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/webrtc_desktop_capture_private_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/webstore_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Devlin
Antony, mind taking a look? I might look into adding a presubmit for these as ...
3 years, 8 months ago (2016-03-26 00:08:32 UTC) #4
asargent_no_longer_on_chrome
3 years, 8 months ago (2016-03-28 17:42:35 UTC) #5
asargent_no_longer_on_chrome
lgtm
3 years, 8 months ago (2016-03-28 17:42:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840453002/20001
3 years, 8 months ago (2016-03-28 18:45:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
3 years, 8 months ago (2016-03-28 19:34:22 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2016-03-28 19:36:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/180e7e74926ea32ac039821926542452d1201c5e
Cr-Commit-Position: refs/heads/master@{#383541}

Powered by Google App Engine
This is Rietveld 408576698