chrome/browser/sync/profile_sync_components_factory_impl.cc - Issue 184043031: Split up extensions storage API implementations for sync and local storage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 184043031: Split up extensions storage API implementations for sync and local storage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments (split_sync) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/storage/settings_frontend.cc ('K') | « chrome/browser/extensions/api/storage/sync_value_store_cache.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_components_factory_impl.cc

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc

index 0e8972c34265789c7d9c8c1277a683a0b8624f87..f8374d7eaa572a54a001010c2d5ca861636140b9 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc

+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc

@@ -9,7 +9,7 @@

#include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/dom_distiller/dom_distiller_service_factory.h"

-#include "chrome/browser/extensions/api/storage/settings_frontend.h"

+#include "chrome/browser/extensions/api/storage/settings_sync_util.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_sync_service.h"

#include "chrome/browser/history/history_service.h"

@@ -471,8 +471,7 @@ base::WeakPtr<syncer::SyncableService> ProfileSyncComponentsFactoryImpl::

return TemplateURLServiceFactory::GetForProfile(profile_)->AsWeakPtr();

case syncer::APP_SETTINGS:

case syncer::EXTENSION_SETTINGS:

- return extensions::SettingsFrontend::Get(profile_)

- ->GetBackendForSync(type)

+ return extensions::settings_sync_util::GetSyncableService(profile_, type)

->AsWeakPtr();

#if defined(ENABLE_APP_LIST)

case syncer::APP_LIST: