chrome/browser/extensions/api/storage/settings_sync_unittest.cc - Issue 184043031: Split up extensions storage API implementations for sync and local storage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/settings_sync_unittest.cc

Issue 184043031: Split up extensions storage API implementations for sync and local storage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments (split_sync) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/storage/settings_frontend.cc ('K') | « chrome/browser/extensions/api/storage/settings_frontend_unittest.cc ('k') | chrome/browser/extensions/api/storage/settings_sync_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/settings_sync_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/settings_sync_unittest.cc b/chrome/browser/extensions/api/storage/settings_sync_unittest.cc

index b60afe108f7e396a522e85a2217e9eaee24fe4c6..72b77ea3758151057599f7621c7845b8c98c06fd 100644

--- a/chrome/browser/extensions/api/storage/settings_sync_unittest.cc

+++ b/chrome/browser/extensions/api/storage/settings_sync_unittest.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/extensions/api/storage/settings_storage_factory.h"

#include "chrome/browser/extensions/api/storage/settings_sync_util.h"

#include "chrome/browser/extensions/api/storage/settings_test_util.h"

+#include "chrome/browser/extensions/api/storage/sync_value_store_cache.h"

#include "chrome/browser/extensions/api/storage/syncable_settings_storage.h"

#include "chrome/browser/extensions/test_extension_service.h"

#include "content/public/test/test_browser_thread.h"

@@ -231,7 +232,9 @@ class ExtensionSettingsSyncTest : public testing::Test {

// Gets the syncer::SyncableService for the given sync type.

syncer::SyncableService* GetSyncableService(syncer::ModelType model_type) {

base::MessageLoop::current()->RunUntilIdle();

- return frontend_->GetBackendForSync(model_type);

+ SyncValueStoreCache* sync_cache = static_cast<SyncValueStoreCache*>(

+ frontend_->GetValueStoreCache(settings_namespace::SYNC));

+ return sync_cache->GetSyncableService(model_type);

}

// Gets all the sync data from the SyncableService for a sync type as a map