Split up extensions storage API implementations for sync and local storage.

chrome/browser/extensions/api/storage/settings_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/json/json_writer.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/storage/settings_frontend.h"
@@ skipping 96 matching lines @@
   }
 
   void FinalReplyWhenSatisfied(
       Namespace settings_namespace,
       const std::string& normal_action,
       const std::string& incognito_action) {
     MaybeLoadAndReplyWhenSatisfied(
         settings_namespace, normal_action, incognito_action, NULL, true);
   }
 
+  syncer::SyncableService* GetSyncableService() {
+    return settings_sync_util::GetSyncableService(browser()->profile(),
+                                                  kModelType);
+  }
+
   void InitSync(syncer::SyncChangeProcessor* sync_processor) {
     base::MessageLoop::current()->RunUntilIdle();
-    SettingsFrontend* frontend = SettingsFrontend::Get(browser()->profile());
-    InitSyncWithSyncableService(sync_processor,
-                                frontend->GetBackendForSync(kModelType));
+    InitSyncWithSyncableService(sync_processor, GetSyncableService());
   }
 
   void SendChanges(const syncer::SyncChangeList& change_list) {
     base::MessageLoop::current()->RunUntilIdle();
-    SettingsFrontend* frontend = SettingsFrontend::Get(browser()->profile());
-    SendChangesToSyncableService(change_list,
-                                 frontend->GetBackendForSync(kModelType));
+    SendChangesToSyncableService(change_list, GetSyncableService());
   }
 
 #if defined(ENABLE_CONFIGURATION_POLICY)
   void SetPolicies(const base::DictionaryValue& policies) {
     scoped_ptr<policy::PolicyBundle> bundle(new policy::PolicyBundle());
     policy::PolicyMap& policy_map = bundle->Get(policy::PolicyNamespace(
         policy::POLICY_DOMAIN_EXTENSIONS, kManagedStorageExtensionId));
     policy_map.LoadFrom(
         &policies, policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER);
     policy_provider_.UpdatePolicy(bundle.Pass());
@@ skipping 432 matching lines @@
   // ENABLE_CONFIGURATION_POLICY is not defined.
   SettingsFrontend* frontend = SettingsFrontend::Get(browser()->profile());
   frontend->DisableStorageForTesting(MANAGED);
   EXPECT_FALSE(frontend->IsStorageEnabled(MANAGED));
   // Now run the extension.
   ASSERT_TRUE(RunExtensionTest("settings/managed_storage_disabled"))
       << message_;
 }
 
 }  // namespace extensions