chrome/browser/extensions/extension_browsertest.cc - Issue 184043024: Limit scope of settings API configuration and proxy permission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 184043024: Limit scope of settings API configuration and proxy permission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move incognito permission test from ChromeExtensionsBrowserClient to ExtensionPrefs Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_browsertest.cc

diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc

index 4cfe0ed0440cbd1d5676e140fd973092c9a02bd6..ca5053ca75fa125c8c68c6210ad5d22a1da94ed7 100644

--- a/chrome/browser/extensions/extension_browsertest.cc

+++ b/chrome/browser/extensions/extension_browsertest.cc

@@ -185,8 +185,7 @@ const Extension* ExtensionBrowserTest::LoadExtensionWithFlags(

content::WindowedNotificationObserver load_signal(

chrome::NOTIFICATION_EXTENSION_LOADED,

content::Source<Profile>(profile()));

- CHECK(!extensions::util::IsIncognitoEnabled(extension_id, profile()) ||

- extension->force_incognito_enabled());

+ CHECK(!extensions::util::IsIncognitoEnabled(extension_id, profile()));

if (flags & kFlagEnableIncognito) {

extensions::util::SetIsIncognitoEnabled(extension_id, profile(), true);