chrome/browser/extensions/api/preference/preference_api.cc - Issue 184043024: Limit scope of settings API configuration and proxy permission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 184043024: Limit scope of settings API configuration and proxy permission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move incognito permission test from ChromeExtensionsBrowserClient to ExtensionPrefs Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/preference/preference_api.cc

diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc

index 93f1c97ad1ebc40b998a60d5009c539d40001cd8..3c30a1dff53d665023767125973f6231e313affe 100644

--- a/chrome/browser/extensions/api/preference/preference_api.cc

+++ b/chrome/browser/extensions/api/preference/preference_api.cc

@@ -453,7 +453,9 @@ void PreferenceAPI::InitExtensionControlledPrefs(

extension_id != extension_ids.end(); ++extension_id) {

base::Time install_time = prefs->GetInstallTime(*extension_id);

bool is_enabled = !prefs->IsExtensionDisabled(*extension_id);

- value_map->RegisterExtension(*extension_id, install_time, is_enabled);

+ bool is_incognito_enabled = prefs->IsIncognitoEnabled(*extension_id);

+ value_map->RegisterExtension(

+ *extension_id, install_time, is_enabled, is_incognito_enabled);

prefs->content_settings_store()->RegisterExtension(

*extension_id, install_time, is_enabled);