Limit scope of settings API configuration and proxy permission

chrome/browser/extensions/api/proxy/proxy_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/extensions/extension_apitest.h"
+#include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/prefs/proxy_config_dictionary.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "extensions/common/extension.h"
 
 namespace extensions {
 
 namespace {
@@ skipping 44 matching lines @@
       EXPECT_FALSE(dict.GetProxyServer(&value));
     }
   }
 
   void ExpectNoSettings(PrefService* pref_service) {
     const PrefService::Preference* pref =
         pref_service->FindPreference(prefs::kProxy);
     ASSERT_TRUE(pref != NULL);
     EXPECT_FALSE(pref->IsExtensionControlled());
   }
+
+  bool SetIsIncognitoEnabled(bool enabled) {
+    ResultCatcher catcher;
+    extensions::util::SetIsIncognitoEnabled(
+        GetSingleLoadedExtension()->id(), browser()->profile(), enabled);
+    if (!catcher.GetNextResult()) {
+      message_ = catcher.message();
+      return false;
+    }
+    return true;
+  }
 };
 
 // Tests direct connection settings.
 IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyDirectSettings) {
   ASSERT_TRUE(RunExtensionTestIncognito("proxy/direct")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension);
 
   PrefService* pref_service = browser()->profile()->GetPrefs();
   ValidateSettings(ProxyPrefs::MODE_DIRECT, kNoServer, kNoBypass, kNoPac,
                    pref_service);
+
+  // As the extension is executed with incognito permission, the settings
+  // should propagate to incognito mode.
+  pref_service = browser()->profile()->GetOffTheRecordProfile()->GetPrefs();
+  ValidateSettings(ProxyPrefs::MODE_DIRECT, kNoServer, kNoBypass, kNoPac,
+                   pref_service);
 }
 
 // Tests auto-detect settings.
 IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyAutoSettings) {
   ASSERT_TRUE(RunExtensionTestIncognito("proxy/auto")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension);
 
   PrefService* pref_service = browser()->profile()->GetPrefs();
   ValidateSettings(ProxyPrefs::MODE_AUTO_DETECT, kNoServer, kNoBypass, kNoPac,
                    pref_service);
 }
 
 // Tests PAC proxy settings.
 IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyPacScript) {
   ASSERT_TRUE(RunExtensionTest("proxy/pac")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension);
 
   PrefService* pref_service = browser()->profile()->GetPrefs();
   ValidateSettings(ProxyPrefs::MODE_PAC_SCRIPT, kNoServer, kNoBypass,
                    "http://wpad/windows.pac", pref_service);
+
+  // As the extension is not executed with incognito permission, the settings
+  // should not propagate to incognito mode.
+  pref_service = browser()->profile()->GetOffTheRecordProfile()->GetPrefs();
+  ExpectNoSettings(pref_service);
+
+  // Now we enable the extension in incognito mode and verify that settings
+  // are applied.
+  ASSERT_TRUE(SetIsIncognitoEnabled(true));
+  ValidateSettings(ProxyPrefs::MODE_PAC_SCRIPT, kNoServer, kNoBypass,
+                   "http://wpad/windows.pac", pref_service);
+
+  // Disabling incognito permission should revoke the settings for incognito
+  // mode.
+  ASSERT_TRUE(SetIsIncognitoEnabled(false));
+  ExpectNoSettings(pref_service);
 }
 
 // Tests PAC proxy settings.
 IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyPacDataUrl) {
   ASSERT_TRUE(RunExtensionTest("proxy/pacdataurl")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension);
   const char url[] =
        "data:;base64,ZnVuY3Rpb24gRmluZFByb3h5R"
        "m9yVVJMKHVybCwgaG9zdCkgewogIGlmIChob3N0ID09ICdmb29iYXIuY29tJykKICAgIHJl"
@@ skipping 174 matching lines @@
       RunExtensionSubtest("proxy/events", "invalid_proxy.html")) << message_;
 }
 
 // Tests error events: PAC script parse error.
 IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyEventsParseError) {
   ASSERT_TRUE(
       RunExtensionSubtest("proxy/events", "parse_error.html")) << message_;
 }
 
 }  // namespace extensions