Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Side by Side Diff: chrome/browser/resources/extensions/extension_list.js

Issue 184043024: Limit scope of settings API configuration and proxy permission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Bernhard's comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="extension_error.js"></include> 5 <include src="extension_error.js"></include>
6 6
7 cr.define('options', function() { 7 cr.define('options', function() {
8 'use strict'; 8 'use strict';
9 9
10 /** 10 /**
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 if (extension.enable_show_button) { 127 if (extension.enable_show_button) {
128 var showButton = node.querySelector('.show-button'); 128 var showButton = node.querySelector('.show-button');
129 showButton.addEventListener('click', function(e) { 129 showButton.addEventListener('click', function(e) {
130 chrome.send('extensionSettingsShowButton', [extension.id]); 130 chrome.send('extensionSettingsShowButton', [extension.id]);
131 }); 131 });
132 showButton.hidden = false; 132 showButton.hidden = false;
133 } 133 }
134 134
135 // The 'allow in incognito' checkbox. 135 // The 'allow in incognito' checkbox.
136 var incognito = node.querySelector('.incognito-control input'); 136 var incognito = node.querySelector('.incognito-control input');
137 incognito.disabled = !extension.incognitoCanBeToggled; 137 incognito.disabled = !extension.incognitoCanBeEnabled;
138 incognito.checked = extension.enabledIncognito; 138 incognito.checked = extension.enabledIncognito;
139 if (!incognito.disabled) { 139 if (!incognito.disabled) {
140 incognito.addEventListener('change', function(e) { 140 incognito.addEventListener('change', function(e) {
141 var checked = e.target.checked; 141 var checked = e.target.checked;
142 butterBarVisibility[extension.id] = checked; 142 butterBarVisibility[extension.id] = checked;
143 butterBar.hidden = !checked || extension.is_hosted_app; 143 butterBar.hidden = !checked || extension.is_hosted_app;
144 chrome.send('extensionSettingsEnableIncognito', 144 chrome.send('extensionSettingsEnableIncognito',
145 [extension.id, String(checked)]); 145 [extension.id, String(checked)]);
146 }); 146 });
147 } 147 }
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 topScroll -= pad / 2; 351 topScroll -= pad / 2;
352 setScrollTopForDocument(document, topScroll); 352 setScrollTopForDocument(document, topScroll);
353 } 353 }
354 }, 354 },
355 }; 355 };
356 356
357 return { 357 return {
358 ExtensionsList: ExtensionsList 358 ExtensionsList: ExtensionsList
359 }; 359 };
360 }); 360 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698