content/renderer/webcrypto/platform_crypto_nss.cc - Issue 184043021: [webcrypto] JWK: Updated import(ext, key_ops) and added export of symmetric keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/webcrypto/platform_crypto_nss.cc

Issue 184043021: [webcrypto] JWK: Updated import(ext, key_ops) and added export of symmetric keys (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wcAesKw_nss1

Patch Set: fixes for eroman Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/webcrypto/jwk.cc ('K') | « content/renderer/webcrypto/jwk.cc ('k') | content/renderer/webcrypto/shared_crypto.h » ('j') | content/renderer/webcrypto/shared_crypto_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/webcrypto/platform_crypto_nss.cc

diff --git a/content/renderer/webcrypto/platform_crypto_nss.cc b/content/renderer/webcrypto/platform_crypto_nss.cc

index 5874e244af2d84e81871832c2cf83151e35a3d31..dad547e8b6870f4b3d69ddef765997b2185d8d15 100644

--- a/content/renderer/webcrypto/platform_crypto_nss.cc

+++ b/content/renderer/webcrypto/platform_crypto_nss.cc

@@ -1190,10 +1190,14 @@ Status UnwrapSymKeyAesKw(const CryptoData& wrapped_key_data,

if (!unwrapped_key)

return Status::Error();

+ blink::WebCryptoKeyAlgorithm key_algorithm;

+ if (!CreateSecretKeyAlgorithm(algorithm, plaintext_length, &key_algorithm))

+ return Status::ErrorUnexpected();

*key = blink::WebCryptoKey::create(new SymKey(unwrapped_key.Pass()),

blink::WebCryptoKeyTypeSecret,

extractable,

- algorithm,

+ key_algorithm,

usage_mask);

return Status::Success();

}