Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184043011: Remove temporary code now that Chrome updated after it got r168165. (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove temporary code now that Chrome updated after it got r168165. BUG=304341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M public/web/WebFrameClient.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jam
I won't CQ this in until the Chrome side is updated after the previous change ...
6 years, 9 months ago (2014-02-28 23:01:56 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-02-28 23:09:09 UTC) #2
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-03 17:09:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184043011/1
6 years, 9 months ago (2014-03-03 17:10:04 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:03:46 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24792
6 years, 9 months ago (2014-03-03 20:03:47 UTC) #6
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-03 20:11:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184043011/1
6 years, 9 months ago (2014-03-03 20:11:45 UTC) #8
jam
The CQ bit was unchecked by jam@chromium.org
6 years, 9 months ago (2014-03-03 20:21:49 UTC) #9
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-03 20:21:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184043011/1
6 years, 9 months ago (2014-03-03 20:22:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184043011/1
6 years, 9 months ago (2014-03-03 23:20:36 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 14:00:48 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=25427
6 years, 9 months ago (2014-03-04 14:00:48 UTC) #14
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-04 15:46:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184043011/1
6 years, 9 months ago (2014-03-04 15:46:26 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 15:46:43 UTC) #17
Message was sent while issue was closed. 
Change committed as 168390

Powered by Google App Engine
This is Rietveld 408576698