src/compiler.cc - Issue 18404009: Refactor JavaScriptFrame::function() to return a JSFunction* and remove associated casts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 18404009: Refactor JavaScriptFrame::function() to return a JSFunction* and remove associated casts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove implicit ASSERT. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 7497f09d51979e50091d47b03e0523433d39168c..c2995773e3fe31d250f1e8ab76e82b848885a28d 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -565,8 +565,7 @@ static Handle<SharedFunctionInfo> MakeFunctionInfo(CompilationInfo* info) {

if (info->is_eval()) {

StackTraceFrameIterator it(isolate);

if (!it.done()) {

- script->set_eval_from_shared(

- JSFunction::cast(it.frame()->function())->shared());

+ script->set_eval_from_shared(it.frame()->function()->shared());

Code* code = it.frame()->LookupCode();

int offset = static_cast<int>(

it.frame()->pc() - code->instruction_start());

« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »