src/frames-inl.h - Issue 18404009: Refactor JavaScriptFrame::function() to return a JSFunction* and remove associated casts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames-inl.h

Issue 18404009: Refactor JavaScriptFrame::function() to return a JSFunction* and remove associated casts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/frames-inl.h

diff --git a/src/frames-inl.h b/src/frames-inl.h

index 8d10645d1d06f9e5a3441eba8b65fbe3043cef86..0b85061d3d7e3ed89f4cc303c40910d19c60e367 100644

--- a/src/frames-inl.h

+++ b/src/frames-inl.h

@@ -274,10 +274,10 @@ inline bool JavaScriptFrame::has_adapted_arguments() const {

}

-inline Object* JavaScriptFrame::function() const {

+inline JSFunction* JavaScriptFrame::function() const {

Object* result = function_slot_object();

ASSERT(result->IsJSFunction());

Toon Verwaest 2013/07/11 15:23:46 You can remove this assert, it's implicit in the c

titzer 2013/07/11 15:30:19 Done.

- return result;

+ return JSFunction::cast(result);

}

« src/frames.cc ('K') | « src/frames.cc ('k') | src/ic.cc » ('j') | no next file with comments »