Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 18404: Added preemption option to d8 (Closed)

Created:
11 years, 11 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Added -p option to d8 that runs a list of source files in a separate thread with preemption enabled.

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -4 lines) Patch
M src/d8.cc View 7 chunks +61 lines, -4 lines 12 comments Download

Messages

Total messages: 3 (0 generated)
Christian Plesner Hansen
11 years, 11 months ago (2009-01-20 12:52:55 UTC) #1
Erik Corry
LGTM. I think one single Locker object can solve all 3 locking issues. http://codereview.chromium.org/18404/diff/1/2 File ...
11 years, 11 months ago (2009-01-20 13:28:30 UTC) #2
Christian Plesner Hansen
11 years, 11 months ago (2009-01-20 14:13:45 UTC) #3
http://codereview.chromium.org/18404/diff/1/2
File src/d8.cc (right):

http://codereview.chromium.org/18404/diff/1/2#newcode449
Line 449: while (ptr) {
Fixed (times 3).

http://codereview.chromium.org/18404/diff/1/2#newcode475
Line 475: Context::Scope context_scope(evaluation_context_);
I don't think so -- there can only be one thread during initialization.

http://codereview.chromium.org/18404/diff/1/2#newcode496
Line 496: Locker::StartPreemption(10);
Right, but I don't want to enable it without the -p option, and this way I don't
have to keep track of when I first meet a -p.

http://codereview.chromium.org/18404/diff/1/2#newcode505
Line 505: // Use all other arguments as names of files to load and run.
Fixed

http://codereview.chromium.org/18404/diff/1/2#newcode520
Line 520: RunShell();
Fixed

Powered by Google App Engine
This is Rietveld 408576698