Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1840343002: Do not show display:none clipPath targets when referenced with <use> (Closed)

Created:
4 years, 8 months ago by pdr.
Modified:
4 years, 8 months ago
Reviewers:
fs
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not show display:none clipPath targets when referenced with <use> This patch fixes a crash when a <use> element references a display:none geometry element. In this scenario there is no layout object and no path to use for clipping, so no clipping should occur. This matches the existing behavior for non-used display:none elements (LayoutSVGResourceClipper::createContentPicture). A test has been added of both direct and indirect display:none clip path children. BUG=598806 Committed: https://crrev.com/ccdb62a9c8970104efc2e127744a7caf35fe8787 Cr-Commit-Position: refs/heads/master@{#384002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/svg/clip-path/display-none-children.html View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/clip-path/display-none-children-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
pdr.
Simple one for a change.
4 years, 8 months ago (2016-03-30 03:09:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840343002/1
4 years, 8 months ago (2016-03-30 03:10:23 UTC) #4
fs
lgtm
4 years, 8 months ago (2016-03-30 07:50:36 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/196022)
4 years, 8 months ago (2016-03-30 09:11:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840343002/1
4 years, 8 months ago (2016-03-30 15:38:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 16:45:38 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 16:46:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccdb62a9c8970104efc2e127744a7caf35fe8787
Cr-Commit-Position: refs/heads/master@{#384002}

Powered by Google App Engine
This is Rietveld 408576698