Add mac toolchain script support to find_sdk script.

Add mac toolchain script support to find_sdk script.

`buildbot_chrome_nacl_stage.py` calls directly into find_sdk.py, add support for
mac toolchain there.

BUG=474373
TBR=thakis@chromium.org

Committed: https://crrev.com/e47e4cb728589eced95417914a35b84a0f724e22
Cr-Commit-Position: refs/heads/master@{#384110}

[justincohen, 2016-03-30 01:50:23]

justincohen@chromium.org changed reviewers:
+ erikchen@chromium.org

[justincohen, 2016-03-30 01:50:23]

This should correct the failure in 

https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.11%20F...

PTAL!

[justincohen, 2016-03-30 13:45:52]

justincohen@chromium.org changed reviewers:
+ mark@chromium.org

[justincohen, 2016-03-30 13:45:52]

+mark@ PTAL!

[erikchen, 2016-03-30 17:39:55]

lgtm

https://codereview.chromium.org/1840323002/diff/1/build/mac/find_sdk.py
File build/mac/find_sdk.py (right):

https://codereview.chromium.org/1840323002/diff/1/build/mac/find_sdk.py#newco...
build/mac/find_sdk.py:45: import mac_toolchain
I've seen python files in our code base that would have these two lines at the
top of the file, along with imports. Would that be cleaner?

https://codereview.chromium.org/1840323002/diff/1/build/mac/find_sdk.py#newco...
build/mac/find_sdk.py:48: os.environ['DEVELOPER_DIR'] = mac_toolchain_dir
2 space indent?

Given that this logic is also present in build/gyp_environment.py, should we
make a new method in mac_toolchain_dir? Mostly trying to avoid duplicated static
strings.

[Mark Mentovai, 2016-03-30 20:00:19]

LGTM

[justincohen, 2016-03-30 21:14:26]

https://codereview.chromium.org/1840323002/diff/1/build/mac/find_sdk.py
File build/mac/find_sdk.py (right):

https://codereview.chromium.org/1840323002/diff/1/build/mac/find_sdk.py#newco...
build/mac/find_sdk.py:45: import mac_toolchain
On 2016/03/30 17:39:55, erikchen wrote:
> I've seen python files in our code base that would have these two lines at the
> top of the file, along with imports. Would that be cleaner?

Done.

https://codereview.chromium.org/1840323002/diff/1/build/mac/find_sdk.py#newco...
build/mac/find_sdk.py:48: os.environ['DEVELOPER_DIR'] = mac_toolchain_dir
On 2016/03/30 17:39:55, erikchen wrote:
> 2 space indent?
> 
> Given that this logic is also present in build/gyp_environment.py, should we
> make a new method in mac_toolchain_dir? Mostly trying to avoid duplicated
static
> strings.

Done.

[justincohen, 2016-03-30 21:15:39]

Description was changed from

==========
Add mac toolchain script support to find_sdk script.

`buildbot_chrome_nacl_stage.py` calls directly into find_sdk.py, add support for
mac toolchain there.

BUG=474373
==========

to

==========
Add mac toolchain script support to find_sdk script.

`buildbot_chrome_nacl_stage.py` calls directly into find_sdk.py, add support for
mac toolchain there.

BUG=474373
TBR=thakis@chromium.org
==========

[justincohen, 2016-03-30 21:15:47]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-03-30 21:15:47]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1840323002/#ps20001
(title: "Create SetToolchainEnvironment method")

[commit-bot: I haz the power, 2016-03-30 21:16:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840323002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840323002/20001

[commit-bot: I haz the power, 2016-03-30 22:08:13]

Description was changed from

==========
Add mac toolchain script support to find_sdk script.

`buildbot_chrome_nacl_stage.py` calls directly into find_sdk.py, add support for
mac toolchain there.

BUG=474373
TBR=thakis@chromium.org
==========

to

==========
Add mac toolchain script support to find_sdk script.

`buildbot_chrome_nacl_stage.py` calls directly into find_sdk.py, add support for
mac toolchain there.

BUG=474373
TBR=thakis@chromium.org
==========

[commit-bot: I haz the power, 2016-03-30 22:08:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-30 22:10:45]

Description was changed from

==========
Add mac toolchain script support to find_sdk script.

`buildbot_chrome_nacl_stage.py` calls directly into find_sdk.py, add support for
mac toolchain there.

BUG=474373
TBR=thakis@chromium.org
==========

to

==========
Add mac toolchain script support to find_sdk script.

`buildbot_chrome_nacl_stage.py` calls directly into find_sdk.py, add support for
mac toolchain there.

BUG=474373
TBR=thakis@chromium.org

Committed: https://crrev.com/e47e4cb728589eced95417914a35b84a0f724e22
Cr-Commit-Position: refs/heads/master@{#384110}
==========

[commit-bot: I haz the power, 2016-03-30 22:10:46]

Patchset 2 (id:??) landed as
https://crrev.com/e47e4cb728589eced95417914a35b84a0f724e22
Cr-Commit-Position: refs/heads/master@{#384110}