Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1840303003: Add <meta> tag YUV JPEG image decoding layout tests (Closed)

Created:
4 years, 8 months ago by Noel Gordon
Modified:
4 years, 8 months ago
Reviewers:
msarett1
CC:
chromium-reviews, blink-reviews, scroggo_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add <meta> tag YUV JPEG image decoding layout tests Based on the test from CL issue 561363002, here updated to use the current <meta> viewport tag that enables GPU rasterization support on Chrome Android, and to include pixel results (which are added here to prevent paint regressions, at least for this very small set of YUV JPEG images). BUG=598949 Committed: https://crrev.com/ba0c7e528c319dd596706d576f094e14b1991b54 Cr-Commit-Position: refs/heads/master@{#384062}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/images/jpeg-ycbcr-vuv-image-decoding.html View 1 chunk +43 lines, -0 lines 1 comment Download

Messages

Total messages: 16 (5 generated)
Noel Gordon
4 years, 8 months ago (2016-03-30 07:23:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840303003/1
4 years, 8 months ago (2016-03-30 07:24:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 08:29:28 UTC) #6
msarett1
LGTM https://codereview.chromium.org/1840303003/diff/1/third_party/WebKit/LayoutTests/fast/images/jpeg-ycbcr-vuv-image-decoding.html File third_party/WebKit/LayoutTests/fast/images/jpeg-ycbcr-vuv-image-decoding.html (right): https://codereview.chromium.org/1840303003/diff/1/third_party/WebKit/LayoutTests/fast/images/jpeg-ycbcr-vuv-image-decoding.html#newcode4 third_party/WebKit/LayoutTests/fast/images/jpeg-ycbcr-vuv-image-decoding.html:4: <meta name="viewport" content="width=device-width, minimum-scale=1.0"> Can you add a ...
4 years, 8 months ago (2016-03-30 13:07:59 UTC) #7
Noel Gordon
The change description and the bug already covers it, no?
4 years, 8 months ago (2016-03-30 19:45:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840303003/1
4 years, 8 months ago (2016-03-30 19:46:12 UTC) #10
msarett
On 2016/03/30 19:45:37, noel gordon wrote: > The change description and the bug already covers ...
4 years, 8 months ago (2016-03-30 19:50:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 19:54:46 UTC) #12
Noel Gordon
On 2016/03/30 19:50:15, msarett wrote: > On 2016/03/30 19:45:37, noel gordon wrote: > > The ...
4 years, 8 months ago (2016-03-30 20:01:43 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ba0c7e528c319dd596706d576f094e14b1991b54 Cr-Commit-Position: refs/heads/master@{#384062}
4 years, 8 months ago (2016-03-30 20:05:39 UTC) #15
Noel Gordon
4 years, 8 months ago (2016-03-30 20:25:58 UTC) #16
Message was sent while issue was closed.
On 2016/03/30 19:50:15, msarett wrote:
> On 2016/03/30 19:45:37, noel gordon wrote:
> > The change description and the bug already covers it, no?
> 
> Well yes, though this information might not be immediately available to
someone
> reading the code.  I'll not nit though, I'm happy with this as is :).

Since I needed to rename the test anyway, I'll add an explicit bug reference to
the test.  Please review https://codereview.chromium.org/1836293004

Powered by Google App Engine
This is Rietveld 408576698