Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 1840303002: ServiceWorker: Enable ExtendableMessageEvent by default (Closed)

Created:
4 years, 8 months ago by nhiroki
Modified:
4 years, 8 months ago
Reviewers:
tkent, falken
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Enable ExtendableMessageEvent by default Before this change, ServiceWorker.postMessage() resulted in MessageEvent fired on ServiceWorkerGlobalScope. After this change, the function call resulted in ExtendableMessaegeEvent fired on the global scope. ExtendableMessageEvent has the same interface/behavior with MessageEvent other than waitUntil(), so this change must not break any existing web pages. Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#extendablemessage-event-section Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fUPpDcnOi64 BUG=598608 Committed: https://crrev.com/176c229259929d70aef76c3ef284b0d1fd0d7037 Cr-Commit-Position: refs/heads/master@{#383939}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
nhiroki
PTAL, thanks!
4 years, 8 months ago (2016-03-30 08:07:32 UTC) #3
falken
lgtm
4 years, 8 months ago (2016-03-30 08:16:27 UTC) #4
nhiroki
+tkent@: Ptal, thanks!
4 years, 8 months ago (2016-03-30 08:26:19 UTC) #8
tkent
lgtm
4 years, 8 months ago (2016-03-30 08:45:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840303002/20001
4 years, 8 months ago (2016-03-30 09:09:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-03-30 09:35:30 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 09:36:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/176c229259929d70aef76c3ef284b0d1fd0d7037
Cr-Commit-Position: refs/heads/master@{#383939}

Powered by Google App Engine
This is Rietveld 408576698