Issue 1840263002: Make a test of summarizing ASTs in strong mode.

Issue 1840263002: Make a test of summarizing ASTs in strong mode. (Closed)

Created:
4 years, 8 months ago by Paul Berry

Modified:
4 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make a test of summarizing ASTs in strong mode. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/fa7f49546bf85bf38768f20fed9a18b63e9436d8

Patch Set 1 #

Total comments: 1

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+312 lines, -85 lines)			Patch
	A	pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart	View		1 chunk	+224 lines, -0 lines	1 comment	Download
	M	pkg/analyzer/test/src/summary/summarize_ast_test.dart	View		2 chunks	+88 lines, -85 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

LGTM https://codereview.chromium.org/1840263002/diff/1/pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart File pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart (right): https://codereview.chromium.org/1840263002/diff/1/pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart#newcode5 pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart:5: library analyzer.test.src.summary.summarize_ast_test; Do we want to add this ...

4 years, 8 months ago (2016-03-29 23:48:00 UTC) #3

Paul Berry

4 years, 8 months ago (2016-03-30 17:34:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fa7f49546bf85bf38768f20fed9a18b63e9436d8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages