Source/core/rendering/InlineTextBox.h - Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineTextBox.h

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: No reference reassignment. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/InlineTextBox.h

diff --git a/Source/core/rendering/InlineTextBox.h b/Source/core/rendering/InlineTextBox.h

index 92926070fc7c5f17572b3b841a7a7c63b7362809..a16bae318381c9d3cc5724cb8491dd050823fc2a 100644

--- a/Source/core/rendering/InlineTextBox.h

+++ b/Source/core/rendering/InlineTextBox.h

@@ -43,7 +43,7 @@ Color correctedTextColor(Color textColor, Color backgroundColor);

class InlineTextBox : public InlineBox {

public:

- InlineTextBox(RenderObject* obj)

+ InlineTextBox(RenderObject& obj)

: InlineBox(obj)

, m_prevTextBox(0)

, m_nextTextBox(0)

@@ -122,7 +122,7 @@ protected:

virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) OVERRIDE;

public:

- RenderText* textRenderer() const;

+ RenderText& textRenderer() const;

private:

virtual void deleteLine() OVERRIDE FINAL;

@@ -197,7 +197,7 @@ private:

DEFINE_INLINE_BOX_TYPE_CASTS(InlineTextBox);

-inline RenderText* InlineTextBox::textRenderer() const

+inline RenderText& InlineTextBox::textRenderer() const

{

return toRenderText(renderer());

}

« no previous file with comments | « Source/core/rendering/InlineFlowBox.cpp ('k') | Source/core/rendering/InlineTextBox.cpp » ('j') | no next file with comments »