Source/core/rendering/EllipsisBox.h - Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/EllipsisBox.h

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated by review comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/EllipsisBox.h

diff --git a/Source/core/rendering/EllipsisBox.h b/Source/core/rendering/EllipsisBox.h

index 149a8512e641060f9c2f2642e65c529121a38eba..c97d375c54a046a49e8c64e8cd74e7cca34ffb79 100644

--- a/Source/core/rendering/EllipsisBox.h

+++ b/Source/core/rendering/EllipsisBox.h

@@ -29,7 +29,7 @@ class HitTestResult;

class EllipsisBox FINAL : public InlineBox {

public:

- EllipsisBox(RenderObject* obj, const AtomicString& ellipsisStr, InlineFlowBox* parent,

+ EllipsisBox(RenderObject& obj, const AtomicString& ellipsisStr, InlineFlowBox* parent,

int width, int height, int x, int y, bool firstLine, bool isVertical, InlineBox* markupBox)

: InlineBox(obj, FloatPoint(x, y), width, firstLine, true, false, false, isVertical, 0, 0, parent)

, m_shouldPaintMarkupBox(markupBox)

« no previous file with comments | « Source/core/editing/VisibleUnits.cpp ('k') | Source/core/rendering/EllipsisBox.cpp » ('j') | Source/core/rendering/RenderObject.h » ('J')