Source/core/rendering/svg/SVGTextLayoutEngine.cpp - Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextLayoutEngine.cpp

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/svg/SVGRootInlineBox.cpp ('K') | « Source/core/rendering/svg/SVGTextChunkBuilder.cpp ('k') | Source/core/rendering/svg/SVGTextQuery.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/SVGTextLayoutEngine.cpp

diff --git a/Source/core/rendering/svg/SVGTextLayoutEngine.cpp b/Source/core/rendering/svg/SVGTextLayoutEngine.cpp

index 7254790fb7f84c9ad7bd12376dc32b04f75cebb2..8f78a67ddafcd6e8f214117c8ad42ceb9ea7e590 100644

--- a/Source/core/rendering/svg/SVGTextLayoutEngine.cpp

+++ b/Source/core/rendering/svg/SVGTextLayoutEngine.cpp

@@ -240,8 +240,7 @@ void SVGTextLayoutEngine::layoutInlineTextBox(SVGInlineTextBox* textBox)

{

ASSERT(textBox);

- RenderSVGInlineText* text = toRenderSVGInlineText(textBox->textRenderer());

- ASSERT(text);

+ RenderSVGInlineText* text = &toRenderSVGInlineText(textBox->textRenderer());

Inactive 2014/02/28 02:28:19 RenderSVGInlineText& text = toRenderSVGInlineText(

ostap 2014/02/28 08:29:14 Done.

ASSERT(text->parent());

ASSERT(text->parent()->node());

ASSERT(text->parent()->node()->isSVGElement());