Source/core/dom/Position.cpp - Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Position.cpp

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Position.cpp

diff --git a/Source/core/dom/Position.cpp b/Source/core/dom/Position.cpp

index 0f5174d0040b263bfc12544805da1a9b560836db..299ee1039c2f100c19cf614bd1f55e1fe4d2d0c7 100644

--- a/Source/core/dom/Position.cpp

+++ b/Source/core/dom/Position.cpp

@@ -677,7 +677,7 @@ Position Position::upstream(EditingBoundaryCrossingRule rule) const

otherBox = otherBox->nextLeafChild();

if (!otherBox)

break;

- if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() > textOffset))

+ if (otherBox == lastTextBox || (&otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() > textOffset))

continuesOnNextLine = false;

}

@@ -686,7 +686,7 @@ Position Position::upstream(EditingBoundaryCrossingRule rule) const

otherBox = otherBox->prevLeafChild();

if (!otherBox)

break;

- if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() > textOffset))

+ if (otherBox == lastTextBox || (&otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() > textOffset))

continuesOnNextLine = false;

}

@@ -801,7 +801,7 @@ Position Position::downstream(EditingBoundaryCrossingRule rule) const

otherBox = otherBox->nextLeafChild();

if (!otherBox)

break;

- if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() >= textOffset))

+ if (otherBox == lastTextBox || (&otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() >= textOffset))

continuesOnNextLine = false;

}

@@ -810,7 +810,7 @@ Position Position::downstream(EditingBoundaryCrossingRule rule) const

otherBox = otherBox->prevLeafChild();

if (!otherBox)

break;

- if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() >= textOffset))

+ if (otherBox == lastTextBox || (&otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() >= textOffset))

continuesOnNextLine = false;

}

« no previous file with comments | « no previous file | Source/core/editing/RenderedPosition.cpp » ('j') | Source/core/editing/VisibleUnits.cpp » ('J')