Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: Source/core/rendering/svg/RenderSVGInline.cpp

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No reference reassignment. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz> 2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz>
3 * Copyright (C) 2006 Apple Inc. All rights reserved. 3 * Copyright (C) 2006 Apple Inc. All rights reserved.
4 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 } 49 }
50 50
51 RenderSVGInline::RenderSVGInline(Element* element) 51 RenderSVGInline::RenderSVGInline(Element* element)
52 : RenderInline(element) 52 : RenderInline(element)
53 { 53 {
54 setAlwaysCreateLineBoxes(); 54 setAlwaysCreateLineBoxes();
55 } 55 }
56 56
57 InlineFlowBox* RenderSVGInline::createInlineFlowBox() 57 InlineFlowBox* RenderSVGInline::createInlineFlowBox()
58 { 58 {
59 InlineFlowBox* box = new SVGInlineFlowBox(this); 59 InlineFlowBox* box = new SVGInlineFlowBox(*this);
60 box->setHasVirtualLogicalHeight(); 60 box->setHasVirtualLogicalHeight();
61 return box; 61 return box;
62 } 62 }
63 63
64 FloatRect RenderSVGInline::objectBoundingBox() const 64 FloatRect RenderSVGInline::objectBoundingBox() const
65 { 65 {
66 if (const RenderObject* object = RenderSVGText::locateRenderSVGTextAncestor( this)) 66 if (const RenderObject* object = RenderSVGText::locateRenderSVGTextAncestor( this))
67 return object->objectBoundingBox(); 67 return object->objectBoundingBox();
68 68
69 return FloatRect(); 69 return FloatRect();
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 RenderInline::removeChild(child); 149 RenderInline::removeChild(child);
150 return; 150 return;
151 } 151 }
152 Vector<SVGTextLayoutAttributes*, 2> affectedAttributes; 152 Vector<SVGTextLayoutAttributes*, 2> affectedAttributes;
153 textRenderer->subtreeChildWillBeRemoved(child, affectedAttributes); 153 textRenderer->subtreeChildWillBeRemoved(child, affectedAttributes);
154 RenderInline::removeChild(child); 154 RenderInline::removeChild(child);
155 textRenderer->subtreeChildWasRemoved(affectedAttributes); 155 textRenderer->subtreeChildWasRemoved(affectedAttributes);
156 } 156 }
157 157
158 } 158 }
OLDNEW
« no previous file with comments | « Source/core/rendering/TrailingFloatsRootInlineBox.h ('k') | Source/core/rendering/svg/RenderSVGInlineText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698