Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No reference reassignment. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderListMarker.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1200 matching lines...) Expand 10 before | Expand all | Expand 10 after
1211 void setShouldRepaintOverflowIfNeeded(bool b) { m_bitfields.setShouldRepaint OverflowIfNeeded(b); } 1211 void setShouldRepaintOverflowIfNeeded(bool b) { m_bitfields.setShouldRepaint OverflowIfNeeded(b); }
1212 1212
1213 private: 1213 private:
1214 // Store state between styleWillChange and styleDidChange 1214 // Store state between styleWillChange and styleDidChange
1215 static bool s_affectsParentBlock; 1215 static bool s_affectsParentBlock;
1216 1216
1217 LayoutRect m_oldRepaintRect; 1217 LayoutRect m_oldRepaintRect;
1218 LayoutRect m_newRepaintRect; 1218 LayoutRect m_newRepaintRect;
1219 }; 1219 };
1220 1220
1221 // Allow equality comparisons of RenderObject's by reference or pointer, interch angeably.
1222 inline bool operator==(const RenderObject& a, const RenderObject& b) { return &a == &b; }
1223 inline bool operator==(const RenderObject& a, const RenderObject* b) { return &a == b; }
1224 inline bool operator==(const RenderObject* a, const RenderObject& b) { return a == &b; }
1225 inline bool operator!=(const RenderObject& a, const RenderObject& b) { return !( a == b); }
1226 inline bool operator!=(const RenderObject& a, const RenderObject* b) { return !( a == b); }
1227 inline bool operator!=(const RenderObject* a, const RenderObject& b) { return !( a == b); }
1228
1221 inline bool RenderObject::documentBeingDestroyed() const 1229 inline bool RenderObject::documentBeingDestroyed() const
1222 { 1230 {
1223 return !document().renderer(); 1231 return !document().renderer();
1224 } 1232 }
1225 1233
1226 inline bool RenderObject::isBeforeContent() const 1234 inline bool RenderObject::isBeforeContent() const
1227 { 1235 {
1228 if (style()->styleType() != BEFORE) 1236 if (style()->styleType() != BEFORE)
1229 return false; 1237 return false;
1230 // Text nodes don't have their own styles, so ignore the style on a text nod e. 1238 // Text nodes don't have their own styles, so ignore the style on a text nod e.
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
1411 void showTree(const WebCore::RenderObject*); 1419 void showTree(const WebCore::RenderObject*);
1412 void showLineTree(const WebCore::RenderObject*); 1420 void showLineTree(const WebCore::RenderObject*);
1413 void showRenderTree(const WebCore::RenderObject* object1); 1421 void showRenderTree(const WebCore::RenderObject* object1);
1414 // We don't make object2 an optional parameter so that showRenderTree 1422 // We don't make object2 an optional parameter so that showRenderTree
1415 // can be called from gdb easily. 1423 // can be called from gdb easily.
1416 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2); 1424 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);
1417 1425
1418 #endif 1426 #endif
1419 1427
1420 #endif // RenderObject_h 1428 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderListMarker.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698