Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: Source/core/rendering/RenderListMarker.cpp

Issue 184023003: Make InlineBox::renderer() and related subclass methods return reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No reference reassignment. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderInline.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.
5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net) 5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
6 * Copyright (C) 2010 Daniel Bates (dbates@intudata.com) 6 * Copyright (C) 2010 Daniel Bates (dbates@intudata.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1099 matching lines...) Expand 10 before | Expand all | Expand 10 after
1110 { 1110 {
1111 return m_image && !m_image->errorOccurred(); 1111 return m_image && !m_image->errorOccurred();
1112 } 1112 }
1113 1113
1114 LayoutRect RenderListMarker::localSelectionRect() 1114 LayoutRect RenderListMarker::localSelectionRect()
1115 { 1115 {
1116 InlineBox* box = inlineBoxWrapper(); 1116 InlineBox* box = inlineBoxWrapper();
1117 if (!box) 1117 if (!box)
1118 return LayoutRect(LayoutPoint(), size()); 1118 return LayoutRect(LayoutPoint(), size());
1119 RootInlineBox* root = inlineBoxWrapper()->root(); 1119 RootInlineBox* root = inlineBoxWrapper()->root();
1120 LayoutUnit newLogicalTop = root->block()->style()->isFlippedBlocksWritingMod e() ? inlineBoxWrapper()->logicalBottom() - root->selectionBottom() : root->sele ctionTop() - inlineBoxWrapper()->logicalTop(); 1120 LayoutUnit newLogicalTop = root->block().style()->isFlippedBlocksWritingMode () ? inlineBoxWrapper()->logicalBottom() - root->selectionBottom() : root->selec tionTop() - inlineBoxWrapper()->logicalTop();
1121 if (root->block()->style()->isHorizontalWritingMode()) 1121 if (root->block().style()->isHorizontalWritingMode())
1122 return LayoutRect(0, newLogicalTop, width(), root->selectionHeight()); 1122 return LayoutRect(0, newLogicalTop, width(), root->selectionHeight());
1123 return LayoutRect(newLogicalTop, 0, root->selectionHeight(), height()); 1123 return LayoutRect(newLogicalTop, 0, root->selectionHeight(), height());
1124 } 1124 }
1125 1125
1126 void RenderListMarker::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffse t) 1126 void RenderListMarker::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffse t)
1127 { 1127 {
1128 ANNOTATE_GRAPHICS_CONTEXT(paintInfo, this); 1128 ANNOTATE_GRAPHICS_CONTEXT(paintInfo, this);
1129 1129
1130 if (paintInfo.phase != PaintPhaseForeground) 1130 if (paintInfo.phase != PaintPhaseForeground)
1131 return; 1131 return;
(...skipping 709 matching lines...) Expand 10 before | Expand all | Expand 10 after
1841 1841
1842 if (clipToVisibleContent) 1842 if (clipToVisibleContent)
1843 computeRectForRepaint(repaintContainer, rect); 1843 computeRectForRepaint(repaintContainer, rect);
1844 else 1844 else
1845 rect = localToContainerQuad(FloatRect(rect), repaintContainer).enclosing BoundingBox(); 1845 rect = localToContainerQuad(FloatRect(rect), repaintContainer).enclosing BoundingBox();
1846 1846
1847 return rect; 1847 return rect;
1848 } 1848 }
1849 1849
1850 } // namespace WebCore 1850 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderInline.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698