More analyzer updates, and handle negative_tests

lib/src/compiler.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Command line tool to run the checker on a Dart program.
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:math' as math;
 import 'dart:io';
@@ skipping 68 matching lines @@
   bool get failure => _failure;
 
   final _pendingLibraries = <List<CompilationUnit>>[];
 
   BatchCompiler(AnalysisContext context, CompilerOptions options,
       {AnalysisErrorListener reporter,
       FileSystem fileSystem: const FileSystem()})
       : super(
             context,
             options,
-            new ErrorCollector(reporter ?? AnalysisErrorListener.NULL_LISTENER),
+            new ErrorCollector(
+                context, reporter ?? AnalysisErrorListener.NULL_LISTENER),
             fileSystem) {
     _inputBaseDir = options.inputBaseDir;
     if (outputDir != null) {
       _jsGen = new JSGenerator(this);
       _runtimeOutputDir = path.join(outputDir, 'dev_compiler', 'runtime');
     }
     _dartCore = context.typeProvider.objectType.element.library;
   }
 
   ErrorCollector get reporter => super.reporter;
@@ skipping 334 matching lines @@
   bool computeErrors(Source source) {
     AnalysisContext errorContext = context;
     // TODO(jmesserly): should this be a fix somewhere in analyzer?
     // otherwise we fail to find the parts.
     if (source.isInSystemLibrary) {
       errorContext = context.sourceFactory.dartSdk.context;
     }
     List<AnalysisError> errors = errorContext.computeErrors(source);
     bool failure = false;
     for (var error in errors) {
-      ErrorCode code = error.errorCode;
-      // Always skip TODOs.
-      if (code.type == ErrorType.TODO) continue;
-
-      // TODO(jmesserly): for now, treat DDC errors as having a different
-      // error level from Analayzer ones.
-      if (isStrongModeError(code)) {
+      // TODO(jmesserly): this is a very expensive lookup, and it has to be
+      // repeated every time we want to query error severity.
+      var severity = errorSeverity(errorContext, error);
+      if (severity == ErrorSeverity.ERROR) {
         reporter.onError(error);
-        if (code.errorSeverity == ErrorSeverity.ERROR) {
-          failure = true;
-        }
-      } else if (code.errorSeverity.ordinal >= ErrorSeverity.WARNING.ordinal) {
-        // All analyzer warnings or errors are errors for DDC.
         failure = true;
+      } else if (severity == ErrorSeverity.WARNING) {
         reporter.onError(error);
-      } else {
-        // Skip hints for now.
       }
     }
     return failure;
   }
 }
 
 // TODO(jmesserly): find a better home for these.
 /// Curated order to minimize lazy classes needed by dart:core and its
 /// transitive SDK imports.
 final corelibOrder = [
@@ skipping 40 matching lines @@
   var files = [
     'harmony_feature_check.js',
     'dart_library.js',
     'dart/_runtime.js',
   ];
   files.addAll(corelibOrder.map(coreToFile));
   return files;
 }();
 
 final _log = new Logger('dev_compiler.src.compiler');