Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 18402007: HasRealIndexedProperty doesn't work on JSGlobalProxy (Closed)

Created:
7 years, 5 months ago by abarth-chromium
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne, adamk, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Visibility:
Public.

Description

HasRealIndexedProperty doesn't work on JSGlobalProxy HasRealIndexedProperty didn't unwrap the JSGlobalProxy and therefore always returned false. BUG=257748 R=adamk@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15610

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M src/objects.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
7 years, 5 months ago (2013-07-09 20:48:48 UTC) #1
adamk
lgtm, but you'll need svenpanne's lgtm for OWNERS. https://codereview.chromium.org/18402007/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/18402007/diff/1/src/objects.cc#newcode12843 src/objects.cc:12843: // ...
7 years, 5 months ago (2013-07-09 21:01:49 UTC) #2
abarth-chromium
Fixed. Thanks!
7 years, 5 months ago (2013-07-09 21:14:11 UTC) #3
rossberg
LGTM too, will land later
7 years, 5 months ago (2013-07-10 09:44:31 UTC) #4
adamk
Committed patchset #2 manually as r15610 (presubmit successful).
7 years, 5 months ago (2013-07-10 19:04:17 UTC) #5
abarth-chromium
7 years, 5 months ago (2013-07-10 19:37:22 UTC) #6
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698