Issue 18402007: HasRealIndexedProperty doesn't work on JSGlobalProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18402007: HasRealIndexedProperty doesn't work on JSGlobalProxy (Closed)

Created:
7 years, 5 months ago by abarth-chromium

Modified:
7 years, 5 months ago

Reviewers:
Sven Panne, adamk, rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/external/v8.git@master

Visibility:
Public.

More Reviews

Description

HasRealIndexedProperty doesn't work on JSGlobalProxy HasRealIndexedProperty didn't unwrap the JSGlobalProxy and therefore always returned false. BUG=257748 R=adamk@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15610

Patch Set 2 : Remove comment #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	src/objects.cc	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
	M	test/cctest/test-api.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm, but you'll need svenpanne's lgtm for OWNERS. https://codereview.chromium.org/18402007/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/18402007/diff/1/src/objects.cc#newcode12843 src/objects.cc:12843: // ...

7 years, 5 months ago (2013-07-09 21:01:49 UTC) #2

adamk

Committed patchset #2 manually as r15610 (presubmit successful).

7 years, 5 months ago (2013-07-10 19:04:17 UTC) #5

Message was sent while issue was closed.

Thanks!

Expand Messages | Collapse Messages

Issue 18402007: HasRealIndexedProperty doesn't work on JSGlobalProxy (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove comment #

Messages