Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 1840193002: Rename "BookmarkThumbnailWidget" to "BookmarkWidget". (Closed)

Created:
4 years, 8 months ago by newt (away)
Modified:
4 years, 8 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename "BookmarkThumbnailWidget" to "BookmarkWidget". "BookmarkThumbnailWidget" is no longer an appropriate name since the widget no longer shows thumbnails. This CL updates the name to simply "BookmarkWidget". BUG=593587 Committed: https://crrev.com/40111482a06887642ae949afdbbf038495608436 Cr-Commit-Position: refs/heads/master@{#383898}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -707 lines) Patch
M build/android/lint/suppressions.xml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/AndroidManifest.xml View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/android/java/res/layout/bookmark_thumbnail_widget.xml View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/android/java/res/layout/bookmark_thumbnail_widget_item.xml View 1 chunk +0 lines, -33 lines 0 comments Download
A + chrome/android/java/res/layout/bookmark_widget.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/java/res/layout/bookmark_widget_item.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/android/java/res/xml/bookmark_thumbnail_widget_info.xml View 1 chunk +0 lines, -17 lines 0 comments Download
A + chrome/android/java/res/xml/bookmark_widget_info.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/com/google/android/apps/chrome/appwidget/bookmarks/BookmarkThumbnailWidgetProvider.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetProviderBase.java View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java View 1 chunk +0 lines, -502 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProvider.java View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java View 1 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
newt (away)
PTAL
4 years, 8 months ago (2016-03-29 20:50:13 UTC) #2
Ian Wen
lgtm!
4 years, 8 months ago (2016-03-29 22:33:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840193002/20001
4 years, 8 months ago (2016-03-29 23:35:59 UTC) #5
newt (away)
Thanks!
4 years, 8 months ago (2016-03-29 23:36:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/42112)
4 years, 8 months ago (2016-03-29 23:50:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840193002/40001
4 years, 8 months ago (2016-03-30 00:32:42 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-30 01:48:35 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 01:49:50 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40111482a06887642ae949afdbbf038495608436
Cr-Commit-Position: refs/heads/master@{#383898}

Powered by Google App Engine
This is Rietveld 408576698