Flip unified media pipeline to default-on w/ disabled holdback.

Flip unified media pipeline to default-on w/ disabled holdback.

Will be merged back to M50 pending launch-approval.

Experiment config will be updated to target M50 stable only at a 95%
disabled rate and slowly ramped down to 0-1% over a couple weeks
to ensure there are no major regressions.

Since there are still some WebView issues to sort out, WebView
has been disabled in this patch set.

Notably on M51 this will also enable 100% of MSE/EME playbacks
onto the unified pipeline. Since MSE only makes up ~9% of
Android playbacks (EME < 1%) and have always been codec restricted,
this is an acceptable risk.

BUG=597495, 598840, 598963
TEST=passes bots.

Committed: https://crrev.com/7defc181e284d5e24a00a9254d4dc7ac3f2c15cb
Cr-Commit-Position: refs/heads/master@{#384451}

[DaleCurtis, 2016-03-30 01:09:45]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 01:10:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840173004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840173004/1

[DaleCurtis, 2016-03-30 01:13:09]

Description was changed from

==========
Flip unified media pipeline to default-on w/ disabled holdback.

Will be merged back to M50 pending launch-approval.

Experiment config will be updated to target stable only at a 95%
disabled rate and slowly ramped down to 0-1% over a couple weeks
to ensure there are no major regressions.

Since there are still some WebView issues to sort out, WebView
has been disabled in this patch set.

BUG=598840
TEST=none
==========

to

==========
Flip unified media pipeline to default-on w/ disabled holdback.

Will be merged back to M50 pending launch-approval.

Experiment config will be updated to target stable only at a 95%
disabled rate and slowly ramped down to 0-1% over a couple weeks
to ensure there are no major regressions.

Since there are still some WebView issues to sort out, WebView
has been disabled in this patch set.

Notably on M51 this will also enable 100% of MSE/EME playbacks
onto the unified pipeline. Since MSE only makes up ~9% of
Android playbacks (EME < 1%) and have always been codec restricted,
this is an acceptable risk.

BUG=598840
TEST=none
==========

[DaleCurtis, 2016-03-30 01:18:15]

Description was changed from

==========
Flip unified media pipeline to default-on w/ disabled holdback.

Will be merged back to M50 pending launch-approval.

Experiment config will be updated to target stable only at a 95%
disabled rate and slowly ramped down to 0-1% over a couple weeks
to ensure there are no major regressions.

Since there are still some WebView issues to sort out, WebView
has been disabled in this patch set.

Notably on M51 this will also enable 100% of MSE/EME playbacks
onto the unified pipeline. Since MSE only makes up ~9% of
Android playbacks (EME < 1%) and have always been codec restricted,
this is an acceptable risk.

BUG=598840
TEST=none
==========

to

==========
Flip unified media pipeline to default-on w/ disabled holdback.

Will be merged back to M50 pending launch-approval.

Experiment config will be updated to target M50 stable only at a 95%
disabled rate and slowly ramped down to 0-1% over a couple weeks
to ensure there are no major regressions.

Since there are still some WebView issues to sort out, WebView
has been disabled in this patch set.

Notably on M51 this will also enable 100% of MSE/EME playbacks
onto the unified pipeline. Since MSE only makes up ~9% of
Android playbacks (EME < 1%) and have always been codec restricted,
this is an acceptable risk.

BUG=598840
TEST=none
==========

[DaleCurtis, 2016-03-30 02:06:03]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 02:06:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840173004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840173004/20001

[commit-bot: I haz the power, 2016-03-30 03:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 03:20:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[DaleCurtis, 2016-03-30 03:33:41]

Description was changed from

==========
Flip unified media pipeline to default-on w/ disabled holdback.

Will be merged back to M50 pending launch-approval.

Experiment config will be updated to target M50 stable only at a 95%
disabled rate and slowly ramped down to 0-1% over a couple weeks
to ensure there are no major regressions.

Since there are still some WebView issues to sort out, WebView
has been disabled in this patch set.

Notably on M51 this will also enable 100% of MSE/EME playbacks
onto the unified pipeline. Since MSE only makes up ~9% of
Android playbacks (EME < 1%) and have always been codec restricted,
this is an acceptable risk.

BUG=598840
TEST=none
==========

to

==========
Flip unified media pipeline to default-on w/ disabled holdback.

Will be merged back to M50 pending launch-approval.

Experiment config will be updated to target M50 stable only at a 95%
disabled rate and slowly ramped down to 0-1% over a couple weeks
to ensure there are no major regressions.

Since there are still some WebView issues to sort out, WebView
has been disabled in this patch set.

Notably on M51 this will also enable 100% of MSE/EME playbacks
onto the unified pipeline. Since MSE only makes up ~9% of
Android playbacks (EME < 1%) and have always been codec restricted,
this is an acceptable risk.

BUG=597495, 598840, 598963
TEST=passes bots.
==========

[DaleCurtis, 2016-03-30 03:35:32]

dalecurtis@chromium.org changed reviewers:
+ asvitkine@chromium.org, ddorwin@chromium.org, watk@chromium.org

[DaleCurtis, 2016-03-30 03:35:32]

This is pending launch review, but is ready for code review.

[DaleCurtis, 2016-03-30 03:37:32]

dalecurtis@chromium.org changed reviewers:
+ boliu@chromium.org, nick@chromium.org

[DaleCurtis, 2016-03-30 03:37:33]

+boliu for android_webview/
+asvitkine for media/base/media.cc changes to field trial.
+nick for content/browser/renderer_host/

ddorwin, watk: for all other media changes.

[DaleCurtis, 2016-03-30 03:38:01]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 03:38:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840173004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840173004/40001

[commit-bot: I haz the power, 2016-03-30 06:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 06:02:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ncarter (slow), 2016-03-30 17:39:55]

https://codereview.chromium.org/1840173004/diff/40001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:110: switches::kEnableLogging,
If the old code required kEnableUnifiedMediaPipeline to be propagated to the gpu
process, why doesn't the kDisable switch need to be propagated?

[DaleCurtis, 2016-03-30 17:46:21]

https://codereview.chromium.org/1840173004/diff/40001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:110: switches::kEnableLogging,
On 2016/03/30 at 17:39:55, ncarter wrote:
> If the old code required kEnableUnifiedMediaPipeline to be propagated to the
gpu process, why doesn't the kDisable switch need to be propagated?

This was left over from old requirements. Nothing in the GPU process uses this
switch anymore. We used to use it when choosing which rendering strategy to use.
We now always use the zero-copy path except when WebView is enabled.

[ncarter (slow), 2016-03-30 18:01:13]

lgtm

[boliu, 2016-03-30 19:24:59]

a_w rs lgtm

[watk, 2016-03-30 19:26:58]

lgtm

[Alexei Svitkine (slow), 2016-03-30 19:28:41]

lgtm

[ddorwin, 2016-03-30 20:16:24]

LGTM with nits and questions.

https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
File media/base/key_systems_unittest.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
media/base/key_systems_unittest.cc:104: if (HasPlatformDecoderSupport())
These are just key system registration tests. What causes these not to be
registered?

https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
media/base/key_systems_unittest.cc:710: if (CanRunExternalKeySystemTests()) {
Use of braces is inconsistent with 690. Pick one?

https://codereview.chromium.org/1840173004/diff/40001/media/base/media.cc
File media/base/media.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/media/base/media.cc#new...
media/base/media.cc:112: !base::StartsWith(group_name, "Disabled",
Do all users already have "Enabled" or "Disabled" set? IOW, this doesn't depend
on a similar switch on the server.

https://codereview.chromium.org/1840173004/diff/40001/media/base/mime_util_un...
File media/base/mime_util_unittest.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/media/base/mime_util_un...
media/base/mime_util_unittest.cc:402: TEST(IsCodecSupportedOnPlatformTest,
HLSDoesNotSupportMPEG2) {
...AAC

[DaleCurtis, 2016-03-30 22:40:15]

https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
File media/base/key_systems_unittest.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
media/base/key_systems_unittest.cc:104: if (HasPlatformDecoderSupport())
On 2016/03/30 at 20:16:24, ddorwin wrote:
> These are just key system registration tests. What causes these not to be
registered?

This is due to your change here I think:
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/key_sys...

[ddorwin, 2016-03-30 22:49:38]

https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
File media/base/key_systems_unittest.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
media/base/key_systems_unittest.cc:104: if (HasPlatformDecoderSupport())
On 2016/03/30 22:40:15, DaleCurtis wrote:
> On 2016/03/30 at 20:16:24, ddorwin wrote:
> > These are just key system registration tests. What causes these not to be
> registered?
> 
> This is due to your change here I think:
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/key_sys...

Thanks. I forgot that code was in KeySystems.

[kyni9487, 2016-03-30 22:57:17]

On 2016/03/30 22:49:38, ddorwin wrote:
>
https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
> File media/base/key_systems_unittest.cc (right):
> 
>
https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
> media/base/key_systems_unittest.cc:104: if (HasPlatformDecoderSupport())
> On 2016/03/30 22:40:15, DaleCurtis wrote:
> > On 2016/03/30 at 20:16:24, ddorwin wrote:
> > > These are just key system registration tests. What causes these not to be
> > registered?
> > 
> > This is due to your change here I think:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/key_sys...
> 
> Thanks. I forgot that code was in KeySystems

> Download comple

[DaleCurtis, 2016-03-31 22:10:33]

Thanks for review. All issues should be resolved. Launch review will occur next
week. After which I'll update the trial configs; until then this will opt-in 80%
of dev (if we actually have a dev cut before then :p)

https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
File media/base/key_systems_unittest.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/media/base/key_systems_...
media/base/key_systems_unittest.cc:710: if (CanRunExternalKeySystemTests()) {
On 2016/03/30 at 20:16:24, ddorwin wrote:
> Use of braces is inconsistent with 690. Pick one?

Done.

https://codereview.chromium.org/1840173004/diff/40001/media/base/media.cc
File media/base/media.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/media/base/media.cc#new...
media/base/media.cc:112: !base::StartsWith(group_name, "Disabled",
On 2016/03/30 at 20:16:24, ddorwin wrote:
> Do all users already have "Enabled" or "Disabled" set? IOW, this doesn't
depend on a similar switch on the server.

The groups are, "Control", "Enabled", "EnabledByFlag", and "Disabled". The
currently meaning in the trial config is opposite of what this change does, but
I'll flip that once we have launch approval.

https://codereview.chromium.org/1840173004/diff/40001/media/base/mime_util_un...
File media/base/mime_util_unittest.cc (right):

https://codereview.chromium.org/1840173004/diff/40001/media/base/mime_util_un...
media/base/mime_util_unittest.cc:402: TEST(IsCodecSupportedOnPlatformTest,
HLSDoesNotSupportMPEG2) {
On 2016/03/30 at 20:16:24, ddorwin wrote:
> ...AAC

Done.

[DaleCurtis, 2016-03-31 22:10:45]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-03-31 22:10:46]

The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org,
watk@chromium.org, boliu@chromium.org, asvitkine@chromium.org,
ddorwin@chromium.org
Link to the patchset: https://codereview.chromium.org/1840173004/#ps60001
(title: "Rebase. Comments. Fix UMA.")

[commit-bot: I haz the power, 2016-03-31 22:11:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840173004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840173004/60001

[commit-bot: I haz the power, 2016-04-01 00:47:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-01 00:48:14]

Description was changed from

==========
Flip unified media pipeline to default-on w/ disabled holdback.

Will be merged back to M50 pending launch-approval.

Experiment config will be updated to target M50 stable only at a 95%
disabled rate and slowly ramped down to 0-1% over a couple weeks
to ensure there are no major regressions.

Since there are still some WebView issues to sort out, WebView
has been disabled in this patch set.

Notably on M51 this will also enable 100% of MSE/EME playbacks
onto the unified pipeline. Since MSE only makes up ~9% of
Android playbacks (EME < 1%) and have always been codec restricted,
this is an acceptable risk.

BUG=597495, 598840, 598963
TEST=passes bots.
==========

to

==========
Flip unified media pipeline to default-on w/ disabled holdback.

Will be merged back to M50 pending launch-approval.

Experiment config will be updated to target M50 stable only at a 95%
disabled rate and slowly ramped down to 0-1% over a couple weeks
to ensure there are no major regressions.

Since there are still some WebView issues to sort out, WebView
has been disabled in this patch set.

Notably on M51 this will also enable 100% of MSE/EME playbacks
onto the unified pipeline. Since MSE only makes up ~9% of
Android playbacks (EME < 1%) and have always been codec restricted,
this is an acceptable risk.

BUG=597495, 598840, 598963
TEST=passes bots.

Committed: https://crrev.com/7defc181e284d5e24a00a9254d4dc7ac3f2c15cb
Cr-Commit-Position: refs/heads/master@{#384451}
==========

[commit-bot: I haz the power, 2016-04-01 00:48:16]

Patchset 4 (id:??) landed as
https://crrev.com/7defc181e284d5e24a00a9254d4dc7ac3f2c15cb
Cr-Commit-Position: refs/heads/master@{#384451}