Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/wtf/text/StringConcatenate.h

Issue 1840163002: Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CHECK in StringConcatenate.h. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/wtf/Deque.h ('K') | « third_party/WebKit/Source/wtf/text/CString.cpp ('k') | third_party/WebKit/Source/wtf/text/StringConcatenate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/text/StringConcatenate.h
diff --git a/third_party/WebKit/Source/wtf/text/StringConcatenate.h b/third_party/WebKit/Source/wtf/text/StringConcatenate.h
index 63a7c4e296292295007d7a15bff37fa10dac4e9e..41e6c099eecd048d9574bb2f40ee9f862dc87eae 100644
--- a/third_party/WebKit/Source/wtf/text/StringConcatenate.h
+++ b/third_party/WebKit/Source/wtf/text/StringConcatenate.h
@@ -171,9 +171,9 @@ public:
bool is8Bit() { return false; }
- NO_RETURN_DUE_TO_CRASH void writeTo(LChar*)
Yuta Kitamura 2016/03/31 04:46:14 Why was this removed?
+ void writeTo(LChar*)
{
- RELEASE_ASSERT(false);
+ CHECK(false);
}
void writeTo(UChar* destination);
« third_party/WebKit/Source/wtf/Deque.h ('K') | « third_party/WebKit/Source/wtf/text/CString.cpp ('k') | third_party/WebKit/Source/wtf/text/StringConcatenate.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698