Issue 1840133004: Fix HttpServerAppTest.WebSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1840133004: Fix HttpServerAppTest.WebSocket. (Closed)

Created:
4 years, 8 months ago by viettrungluu

Modified:
4 years, 8 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/monet.git@master

Target Ref:
refs/heads/master

Project:
monet

Visibility:
Public.

Fix HttpServerAppTest.WebSocket. The Mojo SDK removed the mojo::Array<T> constructor that takes a size (in favor of mojo::Array<T>::New()) and added on that takes nullptr_t. Unfortunately, hilarity ensues in the case of mojo::Array<T>(0). R=jamesr@chromium.org Committed: https://github.com/domokit/moneta5854481c35a9cee2bb090cf0db309e4daf8479c

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/services/network/http_server_apptest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

viettrungluu

4 years, 8 months ago (2016-03-30 17:40:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a5854481c35a9cee2bb090cf0db309e4daf8479c (presubmit successful).