Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 1840113005: Move viewport actions into an ApplyScroll callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled track-word-breaking.html on release too and remove position in defaultWheelEventHandler Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index 586f2396875d60c3d33bb1f71704ccacfe941c69..a919f33eb4397a0ebae5441147f0877da027e2ad 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -1171,6 +1171,13 @@ private:
const OriginAccessEntry& accessEntryFromURL();
+ // Installs the viewport scrolling callback (the "applyScroll" in Scroll
+ // Customization lingo) on the root scrollingElement. This callback is
+ // responsible for viewport related scroll actions like top controls
+ // movement and overscroll glow as well as actually scrolling the root
+ // viewport.
+ void updateViewportApplyScroll();
+
DocumentLifecycle m_lifecycle;
bool m_hasNodesWithPlaceholderStyle;
@@ -1277,6 +1284,10 @@ private:
Member<Element> m_cssTarget;
+ // Not a WeakMember since if we remove the scrolling element we want to keep
+ // it around until we move its ApplyScroll onto the new scrollingElement.
tdresser 2016/04/12 13:59:15 Comment wording is confusing. I think you just ne
bokan 2016/04/12 15:13:53 Done.
+ Member<Element> m_oldScrollingElement;
+
LoadEventProgress m_loadEventProgress;
double m_startTime;

Powered by Google App Engine
This is Rietveld 408576698