third_party/WebKit/Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp - Issue 1840113005: Move viewport actions into an ApplyScroll callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp

Issue 1840113005: Move viewport actions into an ApplyScroll callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/EventHandler.cpp ('K') | « third_party/WebKit/Source/core/page/scrolling/ScrollCustomizationCallbacks.h ('k') | third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp

index e94b0942f014b88381f00892add468525deb4abe..59255bf6fda2ce0bca34d32b0528cb6fc8527ae0 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp

@@ -26,6 +26,11 @@ void ScrollCustomizationCallbacks::setApplyScroll(Element* element, ScrollStateC

m_applyScrollCallbacks.set(element, scrollStateCallback);

}

+void ScrollCustomizationCallbacks::removeApplyScroll(Element* element)

+ m_applyScrollCallbacks.remove(element);

ScrollStateCallback* ScrollCustomizationCallbacks::getApplyScroll(Element* element)

{

auto it = m_applyScrollCallbacks.find(element);

@@ -37,7 +42,7 @@ ScrollStateCallback* ScrollCustomizationCallbacks::getApplyScroll(Element* eleme

#if !ENABLE(OILPAN)

tdresser 2016/04/05 19:31:12 While you're here, can you remove everything with

bokan 2016/04/06 15:21:01 Done.

void ScrollCustomizationCallbacks::removeCallbacksForElement(Element* element)

{

- m_applyScrollCallbacks.remove(element);

+ removeApplyScroll(element);

m_distributeScrollCallbacks.remove(element);

}

#endif