Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 1840113005: Move viewport actions into an ApplyScroll callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase over my own changes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 1014 matching lines...) Expand 10 before | Expand all | Expand 10 after
1025 setHasBoxDecorationBackground(true); 1025 setHasBoxDecorationBackground(true);
1026 } 1026 }
1027 1027
1028 bool LayoutView::allowsOverflowClip() const 1028 bool LayoutView::allowsOverflowClip() const
1029 { 1029 {
1030 return document().settings() && document().settings()->rootLayerScrolls(); 1030 return document().settings() && document().settings()->rootLayerScrolls();
1031 } 1031 }
1032 1032
1033 ScrollResult LayoutView::scroll(ScrollGranularity granularity, const FloatSize& delta) 1033 ScrollResult LayoutView::scroll(ScrollGranularity granularity, const FloatSize& delta)
1034 { 1034 {
1035 // TODO(bokan): This should never get called on the main frame but it
1036 // currently does via the Windows pan scrolling path. That should go through
1037 // a more normalized EventHandler-like scrolling path and we should
1038 // ASSERT(!frame()->isMainFrame()) here. All main frame scrolling should
1039 // be handled by the ViewportScrollCallback.
1040
1035 if (!frameView()) 1041 if (!frameView())
1036 return ScrollResult(); 1042 return ScrollResult(false, false, delta.width(), delta.height());
1037 1043
1038 return frame()->applyScrollDelta(granularity, delta, false); 1044 return frameView()->getScrollableArea()->userScroll(granularity, delta);
1039 } 1045 }
1040 1046
1041 } // namespace blink 1047 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698