Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 1840113005: Move viewport actions into an ApplyScroll callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase over my own changes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 String selectedTextForClipboard() const; 164 String selectedTextForClipboard() const;
165 165
166 PositionWithAffinityTemplate<EditingAlgorithm<NodeTraversal>> positionForPoi nt(const IntPoint& framePoint); 166 PositionWithAffinityTemplate<EditingAlgorithm<NodeTraversal>> positionForPoi nt(const IntPoint& framePoint);
167 Document* documentAtPoint(const IntPoint&); 167 Document* documentAtPoint(const IntPoint&);
168 EphemeralRangeTemplate<EditingAlgorithm<NodeTraversal>> rangeForPoint(const IntPoint& framePoint); 168 EphemeralRangeTemplate<EditingAlgorithm<NodeTraversal>> rangeForPoint(const IntPoint& framePoint);
169 169
170 bool isURLAllowed(const KURL&) const; 170 bool isURLAllowed(const KURL&) const;
171 bool shouldReuseDefaultView(const KURL&) const; 171 bool shouldReuseDefaultView(const KURL&) const;
172 void removeSpellingMarkersUnderWords(const Vector<String>& words); 172 void removeSpellingMarkersUnderWords(const Vector<String>& words);
173 173
174 // FIXME: once scroll customization is enabled everywhere
175 // (crbug.com/416862), this should take a ScrollState object.
176 ScrollResult applyScrollDelta(ScrollGranularity, const FloatSize& delta, boo l isScrollBegin);
177
178 // DisplayItemClient methods 174 // DisplayItemClient methods
179 String debugName() const final { return "LocalFrame"; } 175 String debugName() const final { return "LocalFrame"; }
180 // TODO(chrishtr): fix this. 176 // TODO(chrishtr): fix this.
181 LayoutRect visualRect() const override { return LayoutRect(); } 177 LayoutRect visualRect() const override { return LayoutRect(); }
182 178
183 bool shouldThrottleRendering() const; 179 bool shouldThrottleRendering() const;
184 180
185 // Returns the frame scheduler, creating one if needed. 181 // Returns the frame scheduler, creating one if needed.
186 WebFrameScheduler* frameScheduler(); 182 WebFrameScheduler* frameScheduler();
187 void scheduleVisualUpdateUnlessThrottled(); 183 void scheduleVisualUpdateUnlessThrottled();
188 184
189 bool isNavigationAllowed() const { return m_navigationDisableCount == 0; } 185 bool isNavigationAllowed() const { return m_navigationDisableCount == 0; }
190 186
191 ServiceRegistry* serviceRegistry() { return m_serviceRegistry; } 187 ServiceRegistry* serviceRegistry() { return m_serviceRegistry; }
192 188
193 private: 189 private:
194 friend class FrameNavigationDisabler; 190 friend class FrameNavigationDisabler;
195 191
196 LocalFrame(FrameLoaderClient*, FrameHost*, FrameOwner*, ServiceRegistry*); 192 LocalFrame(FrameLoaderClient*, FrameHost*, FrameOwner*, ServiceRegistry*);
197 193
198 bool shouldScrollTopControls(ScrollGranularity, const FloatSize& delta) cons t;
199
200 // Internal Frame helper overrides: 194 // Internal Frame helper overrides:
201 WindowProxyManager* getWindowProxyManager() const override; 195 WindowProxyManager* getWindowProxyManager() const override;
202 196
203 String localLayerTreeAsText(unsigned flags) const; 197 String localLayerTreeAsText(unsigned flags) const;
204 198
205 void enableNavigation() { --m_navigationDisableCount; } 199 void enableNavigation() { --m_navigationDisableCount; }
206 void disableNavigation() { ++m_navigationDisableCount; } 200 void disableNavigation() { ++m_navigationDisableCount; }
207 201
208 mutable FrameLoader m_loader; 202 mutable FrameLoader m_loader;
209 Member<NavigationScheduler> m_navigationScheduler; 203 Member<NavigationScheduler> m_navigationScheduler;
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 explicit FrameNavigationDisabler(LocalFrame&); 311 explicit FrameNavigationDisabler(LocalFrame&);
318 ~FrameNavigationDisabler(); 312 ~FrameNavigationDisabler();
319 313
320 private: 314 private:
321 Member<LocalFrame> m_frame; 315 Member<LocalFrame> m_frame;
322 }; 316 };
323 317
324 } // namespace blink 318 } // namespace blink
325 319
326 #endif // LocalFrame_h 320 #endif // LocalFrame_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698