Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1840103004: Introduce ThreadHeapStats (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews-bindings_chromium.org, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ThreadHeapStats ThreadHeapStats collect stats about the Heap. BUG=591606 Committed: https://crrev.com/bc43ce961dc073b71d35aa00cdeb174f81c7f8eb Cr-Commit-Position: refs/heads/master@{#384275}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -148 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 3 chunks +42 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 11 chunks +94 lines, -59 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentNode.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 8 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
keishi
4 years, 8 months ago (2016-03-30 03:57:58 UTC) #2
keishi
crbug.com/1842803003 Introduce ProcessHeap crbug.com/1840103004 Introduce ThreadHeapStats <- this crbug.com/1845543002 Rename Heap to ThreadHeap
4 years, 8 months ago (2016-03-30 04:00:02 UTC) #3
haraken
LGTM https://codereview.chromium.org/1840103004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp File third_party/WebKit/Source/platform/heap/Heap.cpp (right): https://codereview.chromium.org/1840103004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp#newcode690 third_party/WebKit/Source/platform/heap/Heap.cpp:690: ThreadHeapStats& Heap::heapStats() Add a TODO and mention that ...
4 years, 8 months ago (2016-03-30 04:37:20 UTC) #4
keishi
https://codereview.chromium.org/1840103004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp File third_party/WebKit/Source/platform/heap/Heap.cpp (right): https://codereview.chromium.org/1840103004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp#newcode690 third_party/WebKit/Source/platform/heap/Heap.cpp:690: ThreadHeapStats& Heap::heapStats() On 2016/03/30 04:37:20, haraken wrote: > > ...
4 years, 8 months ago (2016-03-31 09:29:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840103004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840103004/20001
4 years, 8 months ago (2016-03-31 09:30:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/196894)
4 years, 8 months ago (2016-03-31 11:27:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840103004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840103004/20001
4 years, 8 months ago (2016-03-31 13:28:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 14:42:54 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 14:44:30 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bc43ce961dc073b71d35aa00cdeb174f81c7f8eb
Cr-Commit-Position: refs/heads/master@{#384275}

Powered by Google App Engine
This is Rietveld 408576698