Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1840103002: SkPDF: skia_pdf_less_compression - for debugging only (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
Tom Hudson, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: skia_pdf_less_compression - for debugging only Motivation: as we implement more features in PDF, it would be nice to more easily see what is happening in the output. This change serializes page content as plain text rather than compressed text, but it has to be explicitly enabled with a GYP_DEFINE change: export GYP_DEFINES='skia_pdf_less_compression=1' bin/sync-and-gyp ninja -C out/Debug dm out/Debug/dm --config pdf --src gm -w /tmp GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1840103002 Committed: https://skia.googlesource.com/skia/+/6e26205cece95702d34f935669498b569db72626

Patch Set 1 : 2016-03-29 (Tuesday) 12:43:26 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M gyp/pdf.gyp View 2 chunks +7 lines, -1 line 0 comments Download
M src/pdf/SkPDFStream.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
hal.canary
ptal
4 years, 8 months ago (2016-03-29 16:47:18 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840103002/20001
4 years, 8 months ago (2016-03-29 16:47:26 UTC) #6
tomhudson
LGTM; not worth nitting over debug code that's generally satisfactory.
4 years, 8 months ago (2016-03-29 17:05:22 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 17:06:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840103002/20001
4 years, 8 months ago (2016-03-29 17:09:29 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:10:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/6e26205cece95702d34f935669498b569db72626

Powered by Google App Engine
This is Rietveld 408576698