tests/PathUtilsTest.cpp - Issue 18401005: PathUtilsTest valgrind patch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PathUtilsTest.cpp

Issue 18401005: PathUtilsTest valgrind patch (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PathUtilsTest.cpp

===================================================================

--- tests/PathUtilsTest.cpp (revision 10060)

+++ tests/PathUtilsTest.cpp (working copy)

@@ -64,7 +64,7 @@

int h, int w) {

for (int y = 0; y < h; ++y) { // loop through all pixels

for (int x = 0; x < w; ++x) {

robertphillips 2013/07/13 17:01:08 This change seems correct but makes the test fail

- REPORTER_ASSERT( reporter, *bmp1->getAddr32(x,y) == *bmp1->getAddr32(x,y) );

+ REPORTER_ASSERT( reporter, *bmp1->getAddr32(x,y) == *bmp2->getAddr32(x,y) );

}

return true;

@@ -82,7 +82,9 @@

SkBitmap bmp;

bmp.setConfig(SkBitmap::kARGB_8888_Config, w, h);

bmp.allocPixels();

- SkCanvas(bmp).drawPath(*path, bmpPaint);

+ SkCanvas canvas(bmp);

+ canvas.clear(0xFFFFFFFF);

+ canvas.drawPath(*path, bmpPaint);

// test bmp

test_bmp(reporter, &bmp, truth, h, w);

« no previous file with comments | « no previous file | no next file » | no next file with comments »