[Android, Cast] Take onRouteChanged() into account to discover compatible Cast devices.

[Android, Cast] Take onRouteChanged() into account to discover compatible Cast devices.

BUG=598721
TEST=unit tests + manual testing

Committed: https://crrev.com/4b7cc56984e3014b6b96a7a83a7e1bafc7713c3a
Cr-Commit-Position: refs/heads/master@{#383779}

[whywhat, 2016-03-29 15:55:31]

avayvod@chromium.org changed reviewers:
+ aberent@chromium.org, zqzhang@chromium.org

[whywhat, 2016-03-29 15:55:31]

PTaL

[whywhat, 2016-03-29 15:55:56]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 15:56:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840093002/1

[aberent, 2016-03-29 16:03:13]

https://codereview.chromium.org/1840093002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/DiscoveryCallback.java
(right):

https://codereview.chromium.org/1840093002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/DiscoveryCallback.java:72:
onRouteAdded(router, route);
Will this work correctly if the change means that the route no longer matches
the selector where it previously did?

[commit-bot: I haz the power, 2016-03-29 16:33:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 16:33:56]

Dry run: This issue passed the CQ dry run.

[whywhat, 2016-03-29 16:50:20]

Added a check for matching the selector when route changes

[whywhat, 2016-03-29 16:51:34]

PTAL

https://codereview.chromium.org/1840093002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/DiscoveryCallback.java
(right):

https://codereview.chromium.org/1840093002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/DiscoveryCallback.java:72:
onRouteAdded(router, route);
On 2016/03/29 at 16:03:12, aberent wrote:
> Will this work correctly if the change means that the route no longer matches
the selector where it previously did?

Probably not. I'm not sure if any of the existing MRPs will call onRouteChanged
in that case if we're adding callback without unfiltered events flag. Added a
check though.

[whywhat, 2016-03-29 17:20:04]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 17:20:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840093002/20001

[Zhiqiang Zhang (Slow), 2016-03-29 17:24:07]

lgtm

[aberent, 2016-03-29 17:51:17]

lgtm

[commit-bot: I haz the power, 2016-03-29 18:02:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 18:02:22]

Dry run: This issue passed the CQ dry run.

[whywhat, 2016-03-29 18:36:08]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2016-03-29 18:36:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840093002/20001

[commit-bot: I haz the power, 2016-03-29 18:41:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-29 18:44:02]

Description was changed from

==========
[Android, Cast] Take onRouteChanged() into account to discover compatible Cast
devices.

BUG=598721
TEST=unit tests + manual testing
==========

to

==========
[Android, Cast] Take onRouteChanged() into account to discover compatible Cast
devices.

BUG=598721
TEST=unit tests + manual testing

Committed: https://crrev.com/4b7cc56984e3014b6b96a7a83a7e1bafc7713c3a
Cr-Commit-Position: refs/heads/master@{#383779}
==========

[commit-bot: I haz the power, 2016-03-29 18:44:03]

Patchset 2 (id:??) landed as
https://crrev.com/4b7cc56984e3014b6b96a7a83a7e1bafc7713c3a
Cr-Commit-Position: refs/heads/master@{#383779}