Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1840083002: FreeList::FindNodeFor should not account for node size twice. (Closed)

Created:
4 years, 8 months ago by ulan
Modified:
4 years, 8 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

FreeList::FindNodeFor should not account for node size twice. This fixes available_in_free_list counter. BUG= Committed: https://crrev.com/8d866e6e3f51b4549049684ea4b9c0b6f4f8c432 Cr-Commit-Position: refs/heads/master@{#35111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/heap/spaces.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ulan
PTAL. This fixes the crash on arm64 bot where page live bytes are greater than ...
4 years, 8 months ago (2016-03-29 15:43:10 UTC) #2
Michael Lippautz
Good catch! -- lgtm
4 years, 8 months ago (2016-03-29 15:52:44 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840083002/1
4 years, 8 months ago (2016-03-29 15:55:49 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 16:18:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840083002/1
4 years, 8 months ago (2016-03-29 16:23:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 16:25:11 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 16:25:37 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8d866e6e3f51b4549049684ea4b9c0b6f4f8c432
Cr-Commit-Position: refs/heads/master@{#35111}

Powered by Google App Engine
This is Rietveld 408576698