Recipe for Headless Linux bot

Recipe for Headless Linux bot

BUG=594108
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299628

[perezju, 2016-03-29 15:04:20]

perezju@chromium.org changed reviewers:
+ jbudorick@chromium.org, skyostil@google.com

[perezju, 2016-03-29 15:04:21]

This would be the recipe for the new Headless Linux bot. The .expected file
shows the sequence of bot steps that will be run on the bot.

The corresponding test suite is added at:
https://codereview.chromium.org/1843623002

Please do have a close look, as I only half-know what I'm doing here. :-P

[jbudorick, 2016-03-29 15:13:35]

https://codereview.chromium.org/1840063002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1840063002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1776:
'chromium_config': 'chromium',
This should also have:

  'chromium_apply_config': ['mb']

+ a corresponding src/ side change I'll comment on in the other review.

[Sami, 2016-03-29 15:26:52]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2016-03-29 15:26:52]

Thanks Juan -- looks great to me (although I have very little clue around these
parts).

https://codereview.chromium.org/1840063002/diff/20001/masters/master.chromium...
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/1840063002/diff/20001/masters/master.chromium...
masters/master.chromium.fyi/master.cfg:134: 'Headless Linux',
nit: Should this be "Headless Linux (dbg)"?

[perezju, 2016-03-29 15:37:41]

Applied fixes from both comments. Also just discovered that I can do master
config + recipe changes in the same CL (both live in same repo); so added those
here too.

John, could you have a look at them too?

https://codereview.chromium.org/1840063002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1840063002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1776:
'chromium_config': 'chromium',
On 2016/03/29 15:13:35, jbudorick wrote:
> This should also have:
> 
>   'chromium_apply_config': ['mb']
> 
> + a corresponding src/ side change I'll comment on in the other review.

Change in this CL done.

https://codereview.chromium.org/1840063002/diff/20001/masters/master.chromium...
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/1840063002/diff/20001/masters/master.chromium...
masters/master.chromium.fyi/master.cfg:134: 'Headless Linux',
On 2016/03/29 15:26:52, Sami (OoO) wrote:
> nit: Should this be "Headless Linux (dbg)"?

Done.

[perezju, 2016-03-31 09:29:02]

Ping, John could you have a look?

Reminder: I added the master/slave config in patch set #2.

[jbudorick, 2016-03-31 13:02:05]

lgtm

[perezju, 2016-03-31 15:12:49]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2016-03-31 15:12:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840063002/60001

[commit-bot: I haz the power, 2016-03-31 15:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 15:18:49]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[perezju, 2016-03-31 15:29:50]

perezju@chromium.org changed reviewers:
+ dpranke@google.com

[perezju, 2016-03-31 15:29:50]

Dirk, I think I'm missing an owner for
scripts/slave/recipe_modules/chromium_tests, could you have a look?

Thanks!

[Dirk Pranke, 2016-03-31 18:42:15]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-31 18:42:17]

lgtm w/ comment.

https://codereview.chromium.org/1840063002/diff/60001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1840063002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1788: ],
You should list the compile_targets in //testing/buildbot/chromium.fyi.json
instead, but in order for things to work correctly, you would need to land that
change first, then this change. Or you can leave this as-is and change things
later.

The reason for doing this is so that you can change the compile targets along
with other related src-side changes atomically, and not have to do an additional
build-side change that needs to be coordinated.

[perezju, 2016-04-01 10:47:51]

https://codereview.chromium.org/1840063002/diff/60001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1840063002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1788: ],
On 2016/03/31 18:42:16, Dirk Pranke wrote:
> You should list the compile_targets in //testing/buildbot/chromium.fyi.json
> instead, but in order for things to work correctly, you would need to land
that
> change first, then this change. Or you can leave this as-is and change things
> later.
> 
> The reason for doing this is so that you can change the compile targets along
> with other related src-side changes atomically, and not have to do an
additional
> build-side change that needs to be coordinated.

I went for removing the compile_targets here. Since this is a FYI dashboard I
also think we're OK with landing them in the "wrong" order just to start getting
things going, even if that means having a purple bot for a while until we get
all other pieces in place.

[perezju, 2016-04-01 10:48:05]

The CQ bit was checked by perezju@chromium.org

[perezju, 2016-04-01 10:48:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1840063002/#ps80001
(title: "remove compile_targets")

[commit-bot: I haz the power, 2016-04-01 10:48:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840063002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840063002/80001

[commit-bot: I haz the power, 2016-04-01 10:53:28]

Description was changed from

==========
Recipe for Headless Linux bot

BUG=594108
==========

to

==========
Recipe for Headless Linux bot

BUG=594108

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299628
==========

[commit-bot: I haz the power, 2016-04-01 10:53:29]

Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299628