Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1840053002:
Add tracing events to track sync ipc blocker (Closed)
DescriptionAdd tracing events to track the synchronous IPC blocker
The reply message of a Synchronous IPC was not tracked by existing
tracing points, so the IPC handlers of synchronous IPCs are missed in
the critical paths of other tasks.
This CL adds a flow from the reply to the waiting IPC caller. So that
the IPC handler is trackes as a preceding event of a followings on
chrome://tracing.
BUG=580902
Committed: https://crrev.com/a08b2fdf22ee22090fc7603f6d1784bc15868330
Cr-Commit-Position: refs/heads/master@{#383899}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : +SyncMessageFilter #
Total comments: 2
Messages
Total messages: 23 (13 generated)
Description was changed from ========== Add tracing events to track sync ipc blocker WIP BUG= ========== to ========== Add tracing events to track sync ipc blocker WIP The reply of a Synchronous IPC was not tracked by existing tracing flow, so the IPC handlers of Synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. BUG= ==========
Description was changed from ========== Add tracing events to track sync ipc blocker WIP The reply of a Synchronous IPC was not tracked by existing tracing flow, so the IPC handlers of Synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. BUG= ========== to ========== Add tracing events to track sync ipc blocker WIP The reply of a Synchronous IPC was not tracked by existing tracing flow, so the IPC handlers of Synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. BUG=580902 ==========
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840053002/20001
Description was changed from ========== Add tracing events to track sync ipc blocker WIP The reply of a Synchronous IPC was not tracked by existing tracing flow, so the IPC handlers of Synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. BUG=580902 ========== to ========== Add tracing events to track the synchronous IPC blocker 123456789012345678901234567890123456789012345678901234567890123456789012 The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 ==========
Description was changed from ========== Add tracing events to track the synchronous IPC blocker 123456789012345678901234567890123456789012345678901234567890123456789012 The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 ========== to ========== Add tracing events to track the synchronous IPC blocker The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 ==========
Description was changed from ========== Add tracing events to track the synchronous IPC blocker The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 ========== to ========== Add tracing events to track the synchronous IPC blocker The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. To be considered: Should we add similar ones to SyncMessageFilter? BUG=580902 ==========
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840053002/40001
Description was changed from ========== Add tracing events to track the synchronous IPC blocker The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. To be considered: Should we add similar ones to SyncMessageFilter? BUG=580902 ========== to ========== Add tracing events to track the synchronous IPC blocker The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 ==========
tzik@chromium.org changed reviewers: + tsepez@chromium.org
PTAL
https://codereview.chromium.org/1840053002/diff/40001/ipc/ipc_sync_channel.h File ipc/ipc_sync_channel.h (left): https://codereview.chromium.org/1840053002/diff/40001/ipc/ipc_sync_channel.h#... ipc/ipc_sync_channel.h:159: // Called on the IPC thread when a sync send that runs a nested message loop Why did we remove this?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1840053002/diff/40001/ipc/ipc_sync_channel.h File ipc/ipc_sync_channel.h (left): https://codereview.chromium.org/1840053002/diff/40001/ipc/ipc_sync_channel.h#... ipc/ipc_sync_channel.h:159: // Called on the IPC thread when a sync send that runs a nested message loop On 2016/03/29 16:14:38, Tom Sepez wrote: > Why did we remove this? Because no one uses this and this function touches |done_event|. I'd like to remove this if it's acceptable rather than adding a tracing point to the unused function.
lgtm
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840053002/40001
Message was sent while issue was closed.
Description was changed from ========== Add tracing events to track the synchronous IPC blocker The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 ========== to ========== Add tracing events to track the synchronous IPC blocker The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add tracing events to track the synchronous IPC blocker The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 ========== to ========== Add tracing events to track the synchronous IPC blocker The reply message of a Synchronous IPC was not tracked by existing tracing points, so the IPC handlers of synchronous IPCs are missed in the critical paths of other tasks. This CL adds a flow from the reply to the waiting IPC caller. So that the IPC handler is trackes as a preceding event of a followings on chrome://tracing. BUG=580902 Committed: https://crrev.com/a08b2fdf22ee22090fc7603f6d1784bc15868330 Cr-Commit-Position: refs/heads/master@{#383899} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a08b2fdf22ee22090fc7603f6d1784bc15868330 Cr-Commit-Position: refs/heads/master@{#383899} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
