Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1840033003: Fix iOS compilation after https://codereview.chromium.org/1832933002/ (Closed)

Created:
4 years, 8 months ago by vasilii
Modified:
4 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix iOS compilation after https://codereview.chromium.org/1832933002/ BUG=594110 Committed: https://crrev.com/4d2a4b018c9a712d963105ff57876f19f95b2ae3 Cr-Commit-Position: refs/heads/master@{#383742}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M ios/chrome/browser/passwords/credential_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/passwords/credential_manager.mm View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vasilii
Hi Vaclav, please review.
4 years, 8 months ago (2016-03-29 14:22:42 UTC) #2
vabr (Chromium)
LGTM, thank you for the prompt fix. https://codereview.chromium.org/1840033003/diff/1/ios/chrome/browser/passwords/credential_manager.mm File ios/chrome/browser/passwords/credential_manager.mm (right): https://codereview.chromium.org/1840033003/diff/1/ios/chrome/browser/passwords/credential_manager.mm#newcode296 ios/chrome/browser/passwords/credential_manager.mm:296: // TODO(vasilii): ...
4 years, 8 months ago (2016-03-29 16:02:58 UTC) #3
vasilii
https://codereview.chromium.org/1840033003/diff/1/ios/chrome/browser/passwords/credential_manager.mm File ios/chrome/browser/passwords/credential_manager.mm (right): https://codereview.chromium.org/1840033003/diff/1/ios/chrome/browser/passwords/credential_manager.mm#newcode296 ios/chrome/browser/passwords/credential_manager.mm:296: // TODO(vasilii): update |skip_zero_click| in the store. On 2016/03/29 ...
4 years, 8 months ago (2016-03-29 16:07:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840033003/20001
4 years, 8 months ago (2016-03-29 16:08:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 16:43:45 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 16:45:12 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4d2a4b018c9a712d963105ff57876f19f95b2ae3
Cr-Commit-Position: refs/heads/master@{#383742}

Powered by Google App Engine
This is Rietveld 408576698