Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1840033002: Move popular_sites.* files to c/b/a/ntp (Closed)

Created:
4 years, 8 months ago by markusheintz_
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, Marc Treib, May
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move popular_sites.* files to c/b/a/ntp BUG=596080 Committed: https://crrev.com/48bfbafafb178f8fe624a00d81ced2e0c518d113 Cr-Commit-Position: refs/heads/master@{#383961}

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -406 lines) Patch
M chrome/browser/android/ntp/most_visited_sites.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/android/ntp/popular_sites.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/ntp/popular_sites.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/android/popular_sites.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/android/popular_sites.cc View 1 chunk +0 lines, -286 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/popular_sites_internals_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
markusheintz_
Bernhard PTAL. Thanks
4 years, 8 months ago (2016-03-30 09:36:08 UTC) #3
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-03-30 10:31:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840033002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840033002/40001
4 years, 8 months ago (2016-03-30 12:31:08 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-30 13:09:14 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 13:11:38 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/48bfbafafb178f8fe624a00d81ced2e0c518d113
Cr-Commit-Position: refs/heads/master@{#383961}

Powered by Google App Engine
This is Rietveld 408576698