Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184003002: Remove CreatePlatformFile from content shell. (Closed)

Created:
6 years, 9 months ago by rvargas (doing something else)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Remove CreatePlatformFile from content shell. BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257251

Patch Set 1 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -51 lines) Patch
M base/file_descriptor_posix.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +20 lines, -18 lines 0 comments Download
M chrome/common/local_discovery/local_discovery_messages.h View 2 chunks +5 lines, -1 line 2 comments Download
M components/breakpad/browser/crash_dump_manager_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/breakpad/browser/crash_dump_manager_android.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer.h View 1 chunk +4 lines, -1 line 2 comments Download
M content/browser/renderer_host/media/audio_sync_reader.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
rvargas (doing something else)
PTAL: Brett: base + content Sky: chrome Joi: components Gene: printing
6 years, 9 months ago (2014-03-07 02:27:55 UTC) #1
rvargas (doing something else)
+cdn for local_discovery_messages.h
6 years, 9 months ago (2014-03-07 02:31:41 UTC) #2
sky
LGTM
6 years, 9 months ago (2014-03-07 02:39:29 UTC) #3
gene
lgtm for printing
6 years, 9 months ago (2014-03-07 03:07:39 UTC) #4
brettw
lgtm https://codereview.chromium.org/184003002/diff/220001/content/browser/renderer_host/media/audio_input_sync_writer.h File content/browser/renderer_host/media/audio_input_sync_writer.h (right): https://codereview.chromium.org/184003002/diff/220001/content/browser/renderer_host/media/audio_input_sync_writer.h#newcode12 content/browser/renderer_host/media/audio_input_sync_writer.h:12: #if defined(OS_POSIX) Does this need to be in ...
6 years, 9 months ago (2014-03-07 06:32:25 UTC) #5
Jói
//components LGTM
6 years, 9 months ago (2014-03-07 12:58:54 UTC) #6
rvargas (doing something else)
Thanks https://codereview.chromium.org/184003002/diff/220001/content/browser/renderer_host/media/audio_input_sync_writer.h File content/browser/renderer_host/media/audio_input_sync_writer.h (right): https://codereview.chromium.org/184003002/diff/220001/content/browser/renderer_host/media/audio_input_sync_writer.h#newcode12 content/browser/renderer_host/media/audio_input_sync_writer.h:12: #if defined(OS_POSIX) On 2014/03/07 06:32:25, brettw wrote: > ...
6 years, 9 months ago (2014-03-07 19:16:21 UTC) #7
rvargas (doing something else)
ping cdn
6 years, 9 months ago (2014-03-11 00:39:56 UTC) #8
rvargas (doing something else)
+inferno. Could you take a look at local_discovery_messages.h?
6 years, 9 months ago (2014-03-12 21:48:57 UTC) #9
aarya
On 2014/03/12 21:48:57, rvargas wrote: > +inferno. Could you take a look at local_discovery_messages.h? ping ...
6 years, 9 months ago (2014-03-12 22:16:07 UTC) #10
Tom Sepez
lgtm Messages LGTM. https://codereview.chromium.org/184003002/diff/220001/chrome/common/local_discovery/local_discovery_messages.h File chrome/common/local_discovery/local_discovery_messages.h (right): https://codereview.chromium.org/184003002/diff/220001/chrome/common/local_discovery/local_discovery_messages.h#newcode19 chrome/common/local_discovery/local_discovery_messages.h:19: nit: two ifdef posix blocks back-to-back ...
6 years, 9 months ago (2014-03-12 23:02:15 UTC) #11
rvargas (doing something else)
Thanks! https://codereview.chromium.org/184003002/diff/220001/chrome/common/local_discovery/local_discovery_messages.h File chrome/common/local_discovery/local_discovery_messages.h (right): https://codereview.chromium.org/184003002/diff/220001/chrome/common/local_discovery/local_discovery_messages.h#newcode19 chrome/common/local_discovery/local_discovery_messages.h:19: On 2014/03/12 23:02:16, Tom Sepez wrote: > nit: ...
6 years, 9 months ago (2014-03-12 23:22:00 UTC) #12
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 9 months ago (2014-03-12 23:22:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/184003002/220001
6 years, 9 months ago (2014-03-12 23:24:55 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 23:29:34 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_compile_dbg tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-12 23:29:34 UTC) #16
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 9 months ago (2014-03-14 21:21:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/184003002/220001
6 years, 9 months ago (2014-03-14 21:23:14 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-15 00:09:11 UTC) #19
Message was sent while issue was closed. 
Change committed as 257251

Powered by Google App Engine
This is Rietveld 408576698